Comments (5)
@TN1ck I don't understand how this code works. Won't appliedSelectors
just be an array of the results of running the passed-passed in selectors? Something like: [2, 'cool val', {}]
. So when you run _.merge(...appliedSelectors)
you're going to get garbage out:
{ [Number: 2]
'0': 'c',
'1': 'o',
'2': 'o',
'3': 'l',
'4': ' ',
'5': 'v',
'6': 'a',
'7': 'l' }
from reselect.
Thanks @TN1ck. I think to be more consistent with (state, props)
it should be
let appliedSelectors = selectors.map(fn => {
return fn(_, this.props);
})
from reselect.
Also here is a version with ES6 classes:
import React, { Component } from 'react'
import _ from 'lodash'
const select = (...selectors) => {
return WrappedComponent => class extends Component {
render() {
const appliedSelectors = selectors.map(fn => {
return fn(_, this.props)
})
const calculatedProps = _.merge(...appliedSelectors)
return (
<WrappedComponent {...this.props} {...calculatedProps} />
)
}
}
}
export default select
// Usage:
// select(avatarSelector)(AvatarComponent)
from reselect.
@TN1ck @panayi Great, I appreciate both of you writing this up! Thanks.
@panayi Looks like you are passing lodash as the 1st param into the function getting memoized? I guess that was intended to be a placeholder. I'm not sure that I agree about (_, props)
being more consistent, my initial feeling is that I would leave that function call how @TN1ck had it.
This would be a good fit for this FAQ question on the readme if anyone fancies submitting a pull request. No worries if not, I'll get around to adding it soon.
from reselect.
@TN1ck Sorry, I'm not following what the purpose of this is. Do you have a more concrete example and an explanation of why you can't use reselect in the normal way?
Thanks.
from reselect.
Related Issues (20)
- Investigate potential memory leak issues with `weakmapMemoize` HOT 11
- unstable_autotrackMemoize Errors HOT 1
- How to type redux state and selectors with readonly? HOT 3
- Consider dev mode checks for `x => x` result functions HOT 2
- More Reselect addons to investigate HOT 1
- Add identifiable information to dev mode check log messages HOT 3
- Documentation ignores links in the table of contents entries HOT 1
- Type loss in `createSelector` with inline function declarations passed as separate arguments
- lastResult.deref is not a function (it is undefined) HOT 6
- Better call stack for selector warnings HOT 11
- Unable to use `resultEqualityCheck` with `weakMapMemoize` HOT 3
- Incorrect weakMapMemoize alternative example using useCallback HOT 1
- using createSelector.withTypes prevents build HOT 7
- Question: Why can't we support `createAsyncSelector`? HOT 7
- TypeError: (0 , _reselect.createSelector) is not a function HOT 12
- `weakMapMemoize` with `resultEqualityCheck` is provided empty objects for first call. HOT 3
- Library do not work in Safari < 14.1 HOT 1
- Why the LRUCache implementation is using Array over the Doubly Linked List with Map? HOT 8
- Question: should OutputSelector be used as an InputSelector? HOT 3
- Current documentration loose article about passing parameters HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reselect.