Comments (23)
Please do. Putting libraries under this org not only gives it credibility, but ensures it's maintained by more than just a single person.
from reselect.
Reselect is such an integral part of Redux ecosystem, that it would be beneficial to host it under rackt for the reasons listed above.
from reselect.
I really don't mind one way or the other, so I will defer to everyone else on this.
But while you are here @faassen, would you mind having a quick look at #50 😉
from reselect.
@ellbee I get undeserved credit for this library right now as it's on my github. It's neat people in the community know my name, and I'm happy and proud I helped create this, but I only am one contributor out of a lot of people, some of whom, including you, did more than I did.
from reselect.
Yeah, I appreciate that and I hope that my comment didn't come across as dismissive of the idea. I just wanted to convey that I am totally comfortable with the situation as it is. I do see that there could be benefits to moving the project.
from reselect.
I think this is a great idea. Given the ecosystem's immaturity, it's tough (at least time-consuming) right now to research and choose React technologies. I'm personally more likely to use a project under the rackt org, and it's nice to save a bit of time on due diligence research (granted, I found reselect through redux docs, so I picked it up with only a skim of the docs).
I agree, as mentioned, that it could also result in more users, more PRs, and lower bus factor.
from reselect.
@ellbee No, you did not come across as dismissive at all. I really appreciate your attitude in this towards me a lot!
I contacted Dan Abramov on Twitter and he was in favor of the idea, and he contacted some of the other Rackt people about it. So now we'll see.
from reselect.
Note that concerning the bus factor, @ellbee has complete access to everything already. Well, I said that until I learned that there was still a travis thing. Not sure how to give access there.
from reselect.
Reasonable. Bus factor isn't quite the right term. I think it's more having a slightly larger pool of folks who can spare cycles for reviewing PRs and attending to issues.
Regarding Travis specifically, I think you need owner privilege because you need the "grant privilege' privilege to allow Travis to create web hooks and use build status API.
from reselect.
This sounds like a great idea, and @gaearon thinks so as well. If you're up for it, our door is open.
from reselect.
Okay, back at email I'll initiate the transfer. I wonder whether ellbee's permissions get transferred. We also need to discuss things like npm and travis permissions, but we'll figure it out as we get along.
from reselect.
Okay I've transferred the organization to rackt.
We need to figure out whether these things work:
- we enabled some travis stuff recently, and I had to give some permissions for this. Does it work under rackt?
- ellbee had full access to the reselect repo, and I don't know whether he still does. He really should as he's been the primary maintainer of the project (and initiated the project along with me). I'm not sure whether I have the access to add him; I don't seem to have access to settings myself.
- does rackt have some kind of policy for who has access to the npm for individual projects?
from reselect.
I invited @ellbee to Redux team in rackt.
from reselect.
Thanks. But I didn't give any teams (such as redux) access to reselect. I don't think I even have access myself now. :)
from reselect.
I do still have commit access. But I don't have access to give people access or give teams access. I'm fine with giving the redux team access to the reselect project though.
from reselect.
Alright, I've joined up! 🎉 And I still have access too, so it's looking good. The travis build badge has broken though.
from reselect.
And fixed.
from reselect.
:D welcome!
from reselect.
Thank you!
from reselect.
So any policy for npm?
from reselect.
And welcome ellbee! Yay!
from reselect.
@faassen @ellbee sorry for beeing away for a litte long. Great work on reselect and it's really great that redux is rackt now.
from reselect.
Done.
from reselect.
Related Issues (20)
- Investigate potential memory leak issues with `weakmapMemoize` HOT 11
- unstable_autotrackMemoize Errors HOT 1
- How to type redux state and selectors with readonly? HOT 3
- Consider dev mode checks for `x => x` result functions HOT 2
- More Reselect addons to investigate HOT 1
- Add identifiable information to dev mode check log messages HOT 3
- Documentation ignores links in the table of contents entries HOT 1
- Type loss in `createSelector` with inline function declarations passed as separate arguments
- lastResult.deref is not a function (it is undefined) HOT 6
- Better call stack for selector warnings HOT 11
- Unable to use `resultEqualityCheck` with `weakMapMemoize` HOT 3
- Incorrect weakMapMemoize alternative example using useCallback HOT 1
- using createSelector.withTypes prevents build HOT 7
- Question: Why can't we support `createAsyncSelector`? HOT 7
- TypeError: (0 , _reselect.createSelector) is not a function HOT 12
- `weakMapMemoize` with `resultEqualityCheck` is provided empty objects for first call. HOT 3
- Library do not work in Safari < 14.1 HOT 1
- Why the LRUCache implementation is using Array over the Doubly Linked List with Map? HOT 8
- Question: should OutputSelector be used as an InputSelector? HOT 3
- Current documentration loose article about passing parameters HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reselect.