Comments (2)
It's not really about “keep decorators” or “keep components”.
It's about “which does a better job in which case”.
connect()
connect()
makes more sense as higher order component because:
- You never need to change the selecting function mid-flight. We couldn't do some perf optimizations with
<Connector>
because it had to correctly handle changingselect
prop although there was no valid use for this. - Function-as-a-child default case has performance downsides because people often write it as a lambda so they're allocating functions every time
render
is called. - We have no way to restrict
shouldComponentUpdate
outsideConnector
but that would be really useful to make connected components faster. <Connector>
forced you to write “semi-smart” components that knew about Redux but couldn't, for example, handle its state changes incomponentWillReceiveProps
because they just used<Connector>
inside without access to its state.- Even if you didn't want an intermediate component you had to write it anyway. Now you can
connect()
your dumb component and get the smart component right away, without writing anotherclass
in between.
It was a poor choice of abstraction and added unnecessary layers and clumsiness. We got rid of it.
<Provider>
<Provider>
makes more sense as a normal component.
- Unlike with
connect()
, it actually does make sense to change the parameters (store in this case) at runtime. For server rendering, we want to pass a newstore
for every request. Offering it to specify as a singleton at the top makes server rendering non-obvious. Making it a prop points you to the right direction. - It was a shortcut for shortcut's sake, it didn't bring any valuable opportunities.
- It didn't work well with React Router.
- It didn't work with Redux DevTools.
- It made stubbing store for tests more complicated.
- In React 0.14, we'll be able to further simplify
<Provider>{() => <App />}</Provider>
to<Provider><App /></Provider>
. At this point it's hard to justify@provider
even as a shortcut.
Good riddance.
from react-redux.
Spectacular answer. As usual, thanks for being so thorough.
from react-redux.
Related Issues (20)
- TypeError: dispatcher.useSyncExternalStore is not a function HOT 1
- where development or production mode should be specified? HOT 7
- After some time useSelector stops doing re-renders HOT 8
- Provider properties for dev checks to be passed explicitly to new devModeChecks property HOT 7
- Getting Syntax error for react-redux when building project HOT 4
- Connect not working with detox envinronment HOT 2
- Getting issue in middleware of configureStore when update redux-toolkit to 2.0.1 HOT 1
- useDispatch() causing unexpected navigate back to previous screen HOT 3
- Single global store and two Provider occurs an error for microfrontend app HOT 1
- Test fail with provider in react-native HOT 3
- useSelector hook seems to break hook parsing in React Developer Tools HOT 2
- TypeScript: not possible to use a component's `store` and `context` props when wrapped with `connect` HOC HOT 2
- docs: v9.0.0 release missing information HOT 1
- Connected children components might have mapStateToProps not called HOT 18
- Website search is broken HOT 2
- Hooks API Reference uses misnamed type in the useSelector() example HOT 1
- Include UMD build artifacts for latest release HOT 2
- Unstable selectors causes infinite loop in React
- Can't NPM Install Redux with Vite React + Typescript HOT 2
- Compatibility with React 19 types HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-redux.