Git Product home page Git Product logo

Comments (12)

acdlite avatar acdlite commented on August 16, 2024

I see your point, but I would prefer to keep calling it throw() because it matches the ES6 generator interface.

from redux-actions.

acdlite avatar acdlite commented on August 16, 2024

Oh wait you're suggesting an alias. Yeah let's think about that.

from redux-actions.

johanneslumpe avatar johanneslumpe commented on August 16, 2024

@acdlite how about reject() ?

from redux-actions.

acdlite avatar acdlite commented on August 16, 2024

I was thinking onThrow().

from redux-actions.

johanneslumpe avatar johanneslumpe commented on August 16, 2024

I'm fine with both :) reject() is a tad shorter though :P

from redux-actions.

istarkov avatar istarkov commented on August 16, 2024

+1 reject()

from redux-actions.

acdlite avatar acdlite commented on August 16, 2024

Yeah it's shorter, but it's a totally different word :D It shouldn't seem like a different thing. And I would really prefer everyone use throw(), anyway.

from redux-actions.

johanneslumpe avatar johanneslumpe commented on August 16, 2024

I was just using it because for promises throw() and reject() are almost synonyms. But i don't mind throw() in general. especially because Babel already quotes it by default :)

from redux-actions.

ekmartin avatar ekmartin commented on August 16, 2024

Would be nice with an alias, even though I definitely see the point about keeping with the generator interface. Kind of painful to have to disable linting rules though.

from redux-actions.

lukewestby avatar lukewestby commented on August 16, 2024

@acdlite @johanneslumpe do we want to move forward with the alias?

from redux-actions.

johanneslumpe avatar johanneslumpe commented on August 16, 2024

@lukewestby I personally don't mind having an alias. I'm not really using this lib anymore though. I have converted to just using arrow functions and implicit returns.

from redux-actions.

timche avatar timche commented on August 16, 2024

Since this discussion hasn't come an result, I'll close it for now. Can be reopened if necessary.

from redux-actions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.