Git Product home page Git Product logo

Comments (4)

yangmillstheory avatar yangmillstheory commented on June 27, 2024

Some of the keys above are optional in an FSA - payload, error, and meta, for example.

Your action creator will always have these keys, however.

const [ foo, bar ] = [ 1, undefined ]

console.log({ foo, bar }) // { foo: 1, bar: undefined }

So it's not a valid assumption (if by "signature" you mean "same key-value return shape"), as there exist action creators which output actions without some of the keys mentioned above.

from flux-standard-action.

everking avatar everking commented on June 27, 2024

Thanks for the response @yangmillstheory.

What I meant was the parameter names that it will always have either none, or restricted to the following parameter names payload, error or meta.

function someAction()
function someAction(payload)
function someAction(payload, error)
function someAction(payload, error, meta)

So the following would be invalid/non-compliant:

this.props.someAction(myOwnParam, anotherParam);
...
function someAction(myOwnParam, anotherParam) {
    return {
        type: SOME_ACTION,
        myOwnParam,
        anotherParam
    }
}

Instead should be...

this.props.someAction({myOwnParam, anotherParam});
...
function someAction(payload) {
    return {
        type: SOME_ACTION,
        payload
    }
}

from flux-standard-action.

everking avatar everking commented on June 27, 2024

@yangmillstheory @acdlite - any thoughts?

from flux-standard-action.

JaKXz avatar JaKXz commented on June 27, 2024

I believe this is taken care of by using redux-actions. Closing as stale.

from flux-standard-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.