Git Product home page Git Product logo

Comments (5)

dhimmel avatar dhimmel commented on August 21, 2024 1

It looks like f1ec882 adds ?plain=1 to every GitHub URL, even those that default to plain rendering.

The downside is that it looks like ?plain=1 suppresses embedded code snippets in GitHub comments. See the following URLs and how they render:

https://github.com/reduckted/vscode-gitweblinks/blob/1384c1e5ee29d3b57ae3fbb31fd9140f3e7fadcc/shared/handlers/bitbucket-server.json#L6-L7

https://github.com/reduckted/vscode-gitweblinks/blob/1384c1e5ee29d3b57ae3fbb31fd9140f3e7fadcc/shared/handlers/bitbucket-server.json#L6-L7

https://github.com/reduckted/vscode-gitweblinks/blob/1384c1e5ee29d3b57ae3fbb31fd9140f3e7fadcc/shared/handlers/bitbucket-server.json?plain=1#L6-L7

https://github.com/reduckted/vscode-gitweblinks/blob/1384c1e5ee29d3b57ae3fbb31fd9140f3e7fadcc/shared/handlers/bitbucket-server.json?plain=1#L6-L7

https://github.com/reduckted/vscode-gitweblinks/blob/1384c1e5ee29d3b57ae3fbb31fd9140f3e7fadcc/README.md?plain=1#L14-L16

https://github.com/reduckted/vscode-gitweblinks/blob/1384c1e5ee29d3b57ae3fbb31fd9140f3e7fadcc/README.md?plain=1#L14-L16

IMO this is a GitHub bug. ?plain=1 should not suppress embedded code snippets (I emailed support). But since it does, I wonder if ?plain=1 should only be added to files ending with .md or .markdown?

from gitweblinks.

lalten avatar lalten commented on August 21, 2024 1

@reduckted the plain is a pain because I need to manually remove it to get the previews as @dhimmel shows. Any chance this could be made configurable, or @dhimmel's suggestion implemented?

from gitweblinks.

reduckted avatar reduckted commented on August 21, 2024

Thanks for the info. I've added this v2.5.1 which is available in the marketplace now.

from gitweblinks.

dhimmel avatar dhimmel commented on August 21, 2024

Thanks! Noting f1ec882 as the relevant commit.

from gitweblinks.

reduckted avatar reduckted commented on August 21, 2024

I've improved this in 4b1b35e. The ?plain=1 is only added to markdown files (.md or .markdown).

Version 2.5.3 should be available on the marketplace shortly.

from gitweblinks.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.