Comments (1)
So when looking at the last build for the repo that included code that includes not gofmt
-ed code, in Line 242 onwards of the build:
$ make validate
for pkg in ./pkg/... ./cli/... ./cmd/...; do \
echo "Running golint on $i:"; \
golint $i; \
done;
Running golint on :
Running golint on :
Running golint on :
# get all go files and run go fmt on them
files=$(find . -name '*.go' -not -path "./vendor/*" | xargs gofmt -l); if [[ -n "$files" ]]; then \
echo "Error: 'gofmt ' needs to be run on:"; \
echo "${files}"; \
exit 1; \
fi;
/bin/sh: 1: [[: not found
go vet ./pkg/... ./cli/... ./cmd/...
It looks like travis doesn't care about the exit code of the before_script
, and there are some issues with it running make validate
.
I think it's because dash/sh
don't support [[
.
The Travis CI docs say before_script
exiting with a non-zero code will error the build, but it doesn't seem to be, so [[ not found
must exit with a zero exit code.
Taking a look.
from spread.
Related Issues (20)
- Cannot update version throught `go get` HOT 2
- kubectl client 1.2.0 seems to have an issue with spread 0.0.3 HOT 2
- Switch integration tests to use specific localkube version
- Support google-json-key for authentication through Gitlab CI HOT 1
- Support hostname for LoadBalancer L4 ingress
- Generate files from structured data
- Add objects to index HOT 1
- Not working with Docker for Mac HOT 6
- Managing secrets HOT 2
- Endless 'Waiting for load balancer deployment...' HOT 1
- Gitlab CI HOT 6
- Job support
- Ingress support
- How to deploy to GCE? HOT 1
- Gitlab CI - Conditional deploys
- Building the gitlab image fails HOT 1
- No binaries are available in the v1.0.0 release.
- This is the issue that was promised
- Deprecated? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spread.