Comments (3)
This seems reasonable to me, and I'll be happy to commit it. For that matter,
maybe we should be using a makefile (or *something* other than a shell
script...)
Thanks for the patch.
Original comment by [email protected]
on 11 Feb 2015 at 7:40
- Added labels: ****
- Removed labels: ****
from cld2.
BTW with around 20 cmake lines you can have everything working correctly.
that kind of build scripts are really painful for every kind of usage.
you are using -m64, this is wrong to me, do you want to exclude everybody using
a non64 arch?
Original comment by [email protected]
on 11 Feb 2015 at 7:55
- Added labels: ****
- Removed labels: ****
from cld2.
This is committed, along with some other minor tweaks (warning messages and the
SONAME bits you asked for in issue 29) in r194.
Regarding your comment in #2: CLD's primary consumer is the Chromium
open-source project, which doesn't use these scripts at all - it has a
completely custom build system (GYP/GN and ninja) that have their own "unique"
mechanisms for setting the various flags and options. The shell scripts are
really just for hand-running tests and tweaking the build, it's kind of
expected that an embedder would have their own tech for building that they'd
want to pull this into.
I'm happy to take submissions for more robust (and simple) build logic! If
you're willing to write it up, send it along and if it looks reasonable we'll
get it committed and credit you in the commit message.
Original comment by [email protected]
on 12 Feb 2015 at 11:26
- Changed state: Fixed
- Added labels: ****
- Removed labels: ****
from cld2.
Related Issues (20)
- SIGBUS on ARM32 in utf8statetable.cc:517 HOT 13
- compact_lang_det.h: loadDataFromRawAddress should use types from stdint.h instead of "int" HOT 3
- Can't link "dynamic" and "full" HOT 3
- CLD2DynamicDataLoader calls delete instead of delete[] on array types HOT 4
- The ISO 639 code for Hebrew is outdated HOT 1
- Consider declaring dynamic data methods unconditionally HOT 3
- CLD2 result chunk vector omits portions of input file HOT 6
- Dynamic data loading should not use iostream HOT 5
- Windows build fails: undeclared identifier 'close' HOT 6
- Support mmap-ing dynamic data on win32 HOT 5
- Build warning on Windows with clang HOT 2
- Eliminate redundancy and/or simplify default case for compiling unittest_data.h HOT 4
- Missing include in cld2_dynamic_data_loader.cc HOT 1
- cld2_dynamic_data.cc and cld2_dynamic_data_loader.cc problems on Win32 HOT 10
- Enable dynamic data for 20141015 release HOT 1
- New GCC 5.0 hits problem with narrowing in list-initializers
- CLD should check result of "new" in all use cases
- please provide a SONAME HOT 9
- cld2 testsuite failures HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cld2.