Request textDocument/rangeFormatting failed about languageserver HOT 11 CLOSED

It is VSCode specific issue, but there is more going on here. The problem is, in range formatting, we always get the full lines of the selection.

When you paste "a" to "p", the text being formatted is

  colnames = c("a", "b", "c", "d", "e",
  "f", "g", "h", "i", "j", "k", "l",
  "m", "n", "o", "p")))

That's why we get an error.

The easiest fix is to catch the possible error of style_text since we cannot predict what will be passed to it.

Does VSCode really expect to run formatting for every paste? Sometime user may copy and paste an incomplete piece of code and obviously we don't want to format it.

from languageserver.

In vscode, there are formatOnType, formatOnPaste, and formatOnSave options. I think such formatting error can be suppressed unless debug mode is on.

from languageserver.

I believe that the error is suppressed when debug mode is off, isn't it?

from languageserver.

My debug mode is off but this still appears.

from languageserver.

Note that you will need to restart VSCode. You are right.

from languageserver.

The problem is more complicated when I thought.

foo <- function(
		x = 1,
		y = 2
	) {
	# body
}

If I paste z = 1 to replace y = 2. I got

foo <- function(
		x = 1,
		z <- 1
	) {
	# body
}

from languageserver.

I guess we need to check if the selection is from the beginning to the end of all the lines included.

from languageserver.

This example is caused by assignment operator fix, even if you select the full line, the formatting would make this happen, doesn't it?

from languageserver.

Yes, it would still be an issue. But at least it is not triggered all the times. A better solution is to check the scope of the selection. But it can be difficult in some situations.

from languageserver.

Maybe we can turn off operator replace by default?

from languageserver.

Use format selection in vscode will make this happen too.

Operator replacement is dangerous because <- and = are not always interchangeable. I think we should turn if off by default as an argument of style_text.

from languageserver.