range formatting ignores current indentation about languageserver HOT 5 CLOSED

Perhaps we could detect the indentation of the original first line and prepend it to all the lines.

from languageserver.

Thanks for the fix!

For the demo code above, if I copy

  x <- rnorm(n)
  y <- 3 + 2 * x + rnorm(n)
  m <- lm(y ~ x)
  coef(m)

which has indentation of 2 spaces.

And start a new line in the body of g, I will automatically get an indentation of 2 spaces, as the following shows where | represents my cursor:

g <- functon(x) {
  |
}

If I paste the code at the cursor, I'll get

g <- functon(x) {
    x <- rnorm(n)
    y <- 3 + 2 * x + rnorm(n)
    m <- lm(y ~ x)
    coef(m)
}

which has 4-space indentation. However, the desired result for me is still 2-space indentation because it fits the indentation of the function body.

I'm wondering if it makes sense that the copied string be styled first (which removes its indentation) and put it to the cursor (which repects the indentation of the cursor as just implemented)?

from languageserver.

It is a VS code specific behavior. I don’t think we have any control of it.

from languageserver.

I'm a bit confused about which behavior is vscode-specific, or provided by vscode extensions. But the latest version is good enough for me. Thanks!

from languageserver.

The language server is only allowed to return what the protocol is allowed. For range formatting, we could only return a list of text edits (i.e., modified text). We cannot control the extra indentation based on the current cursor. In fact, the language server doesn't know where the cursor is at.

from languageserver.