Git Product home page Git Product logo

Comments (4)

filipecosta90 avatar filipecosta90 commented on June 17, 2024 1

hi there @LeonOnRoad , #86 address it ( PS: feel free to open PRs when you have code portions like the above... I basically copy pasted yours, just changed the name of the function (given that DeleteKey IMHO is to much generic ) and added the example ).

Even though DeleteSerie basically being sugar coating on the go client that calls DEL command I tend to agree that having a documented and exemplified DeleteSerie will make the usage more clearer.

Wanted to confirm with @danni-m what he thinks about it.

from redistimeseries-go.

LeonOnRoad avatar LeonOnRoad commented on June 17, 2024

For the moment I implemented the following workaround in my code:

func DeleteKey(client *redistimeseries.Client, key string) error {
	conn := client.Pool.Get()
	defer conn.Close()

	_, err := conn.Do("DEL", key)

	return err
}

from redistimeseries-go.

LeonOnRoad avatar LeonOnRoad commented on June 17, 2024

Hi @filipecosta90 ,
Thanks for accepting my change request. That was super fast! 👍
I agree on the naming.

LGTM

This issue can be closed. Thanks!

from redistimeseries-go.

filipecosta90 avatar filipecosta90 commented on June 17, 2024

@LeonOnRoad we've just released it on 1.4.3
Thank you for bringing this subject up!

from redistimeseries-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.