Multiple locking of RLock reset remainTimeToLive to config default about redisson HOT 7 CLOSED

Fixed. Thanks for report

from redisson.

A variation on the example given above is:

RedissonClient redisson = Redisson.create(config);
RLock lock = redisson.getLock("test-lock:1");
lock.lock(10, TimeUnit.SECONDS);
Thread.sleep(5000);
lock.lock(10, TimeUnit.SECONDS);
lock.unlock();
System.out.println(lock.remainTimeToLive());

Should the remainTimeToLive be 10 seconds or 5 seconds?

Another one:

RedissonClient redisson = Redisson.create(config);
RLock lock = redisson.getLock("test-lock:1");
lock.lock(10, TimeUnit.SECONDS);
lock.lock(5, TimeUnit.SECONDS);
lock.unlock();
System.out.println(lock.remainTimeToLive());

Should the remainTimeToLive be 10 seconds or 5 seconds?

from redisson.

Hi @mrniko, do you know if there is some plan to fix this in a next patch version? Or is there something I can do to help?

from redisson.

A variation on the example given above is:

RedissonClient redisson = Redisson.create(config);
RLock lock = redisson.getLock("test-lock:1");
lock.lock(10, TimeUnit.SECONDS);
Thread.sleep(5000);
lock.lock(10, TimeUnit.SECONDS);
lock.unlock();
System.out.println(lock.remainTimeToLive());

Should the remainTimeToLive be 10 seconds or 5 seconds?

Another one:

RedissonClient redisson = Redisson.create(config);
RLock lock = redisson.getLock("test-lock:1");
lock.lock(10, TimeUnit.SECONDS);
lock.lock(5, TimeUnit.SECONDS);
lock.unlock();
System.out.println(lock.remainTimeToLive());

Should the remainTimeToLive be 10 seconds or 5 seconds?

first example is about 10 seconds. Second example is about 5 seconds. I have checked your examples. Results are correct.

from redisson.

I have checked your examples. Results are correct.

Ok, so you didn't reproduce the problem I was experiencing where lock, lock, unlock would result with a time to live to be the default 30seconds instead?

I will check again with latest version and close this if it's all good. Thank you for looking into it.

from redisson.

So, yes, indeed, it works as expected, so I'm not sure what happens in my particular environment (because I have built abstractions on top of Redisson and I had tests that are now failing with 3.19.2+).

I will close this ticket then and reopen one if needed. Sorry again for the noise :)

from redisson.

Well, that was fast, actually the bug is really there, the repro is the same as in the description but with a twist:

RedissonClient redisson = Redisson.create(config);
RLock lock = redisson.getLock("test-lock:1");
lock.lock(10, TimeUnit.SECONDS);
lock.lock(10, TimeUnit.SECONDS);
lock.lock(10, TimeUnit.SECONDS);
lock.unlock();
lock.unlock();
System.out.println(lock.remainTimeToLive()); // prints something close to the config default of 30 000

from redisson.