Comments (5)
Not sure what do you mean. Right now pipelining in handled as it is handled by most of the clients.
You just keep sending commands without waiting and reading replies. And when you finish sending commands you read all the replies.
Today this increases performance from 23k of ops to 140k of ops, which is a HUGE boost.
If you need more info about how to do pipelining with Jedis you can find it here: https://github.com/xetorthio/jedis/wiki under Pipelining
Let me know if I misunderstood anything. Thanks!
from jedis.
My understanding is that one could issue multiple commands in the same write to the server rather then doing multiple write operations. I haven't seen that happening in Jedis but maybe I've missed something.
On the same topic, the current API requires a 'callback' approach in which one adds all the commands in the JedisPipeline class which then executed by Jedis. For our use case, we're interested in having something like:
- start pipeline
- do op
- do op (and so on)
- stop pipeline
We don't have any control over the client so we'd like to enable batching/pipelining - invoke the client and then disable pipelining once returned. Currently we can't do that.
Could you improve the API so the workflow mentioned above could be supported?
Something like startPipelining/Batch ?
Thanks,
from jedis.
Sorry - seems that I accidentally closed the issue while submitting my previous comment - that wasn't my intention.
from jedis.
I think we are OK with the pipelining approach. But it you have in mind how you can improve it, I will be more than happy to receive a pull request or even discuss in more details you solution :)
And regard the pipelining usage. Maybe I could add something like it is in multi, where you can provide a callback or get a Transaction and work on that. It will be like this:
Pipeline p = jedis.pipeline();
p.set("foo", "bar");
p.get("something");
List results = p.close();
Is that OK?
from jedis.
That would be great. I guess you could create a common interface to avoid duplicating all the methods all over between Jedis/Transaction and Pipeline.
Cheers,
from jedis.
Related Issues (20)
- unable to connect to Google Memorystore HOT 4
- Could not get a resource from the pool HOT 7
- Jedis4 cannot close SentinelListener connection completely in a JedisSentineled mode when executing method close ,caused connection leak
- redis.clients.jedis.exceptions.JedisException: Could not get a resource from the pool
- redis.clients.jedis.exceptions.JedisException: Could not get a resource from the pool at redis.clients.jedis.util.Pool.getResource(Pool.java:42) ~[jedis-5.1.2.jar:?] at redis.clients.jedis.JedisPool.getResource(JedisPool.java:378) ~[jedis-5.1.2.jar:?] HOT 2
- JedisPooled ## Could not get a resource from the pool HOT 5
- redis.clients.jedis.exceptions.JedisConnectionException: Unexpected end of stream. HOT 4
- Resource leak: JedisPooled does not return connection to the pool on socket exception HOT 1
- Jedis connect failed when using dns resolver in jedis 5.1.2 HOT 5
- Pipeline is invalid HOT 2
- Performance issue version 5.1.3
- Empty lua table returns EmptyMap since 5.0.1
- redis.clients.jedis.exceptions.JedisConnectionException: Failed to connect to any host resolved for DNS name. HOT 1
- Failed to connect to any host resolved for DNS name. HOT 1
- Java 21 and Virtual Threads: Timeout waiting for idle object HOT 2
- Refresh connections when getting JedisMovedDataException during using pipeline HOT 1
- Does jedis support valkey connections ? HOT 1
- Virtual threads permanently blocking on JedisPool#getResource
- BZPOPMIN & BZPOPMAX throws NPE when sorted set is empty
- readOnlyForReplica flag question HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jedis.