hiredis-rb is not GC-safe about hiredis-rb HOT 26 OPEN

I'm not working on hiredis-rb anymore.

from hiredis-rb.

Thanks for the report. I'm quite busy this and the coming week, but I will look into this.

from hiredis-rb.

Thanks @badboy - At first read, does the addition of volatile to the VALUEs make sense?

from hiredis-rb.

@badboy - Get a chance to look at this?

from hiredis-rb.

@badboy Is there anyone else I can @tag here to get a set of eyes on this issue?

from hiredis-rb.

Hey. Currently I'm the only maintainer, so there's no one else to take a look.
But I did and it seems there is a macro to use (RB_GC_GUARD) on those VALUEs instead of making it explicitely volatile.

I'm trying to find the right solution today.

from hiredis-rb.

@findchris Do you have a test case that triggers the bug reliably? Would be nice to know that any fix we apply actually solves the problem (the other option for me would be to read the assembly and I'm really not good at that)

from hiredis-rb.

@badboy I don't have a test case, sadly. It seems to be GC-related, and I have been able to reproduce consistently.

@ohler55 Did this comment make sense to you? I just don't know enough to respond intelligently.

from hiredis-rb.

@badboy and @ohler55 - Any chance to check this out, or is it dying on the vine here?

from hiredis-rb.

Glad to get involved. Do you have a set of changes? Need a some help and a PR?

from hiredis-rb.

I don't have any code yet.
I can't even reproduce it, which makes it near to impossible to know if any change would actually cover the bug. I appreciate all help, so if you have more insight or know your way around in Ruby extensions (I really don't :D) please tell so.

from hiredis-rb.

ok, I'll put together some change and attempt to put together a test. It will be a step at a time.

from hiredis-rb.

Thanks in advance!

from hiredis-rb.

Thanks guys; I really appreciate you stepping up on this @ohler55 👏

from hiredis-rb.

I am not having much success reproducing the failure here. @findchris, can you run tests on changes we make to verify when the changes work? You can be our tester. Less than ideal but it should be enough.

from hiredis-rb.

I can lock production to a particular commit, which should work.

from hiredis-rb.

It would help a lot. I put up a PR. Maybe batboy can help get everything squared away on branches.

from hiredis-rb.

Thanks @ohler55.
@badboy Can you look at #43?

from hiredis-rb.

@badboy Did you get a chance to review #43?

from hiredis-rb.

Checking in @badboy #squeakywheel

from hiredis-rb.

I'm sorry this is post-poned so long, but I have to shift it a bit again (upcoming holiday and I just need a break from this). I take a fresh look when I'm back in 2 weeks.

from hiredis-rb.

Totally understandable. Enjoy your holiday!

from hiredis-rb.

This is still an issue for us.

@badboy - Did you get a chance to look at this issue?

from hiredis-rb.

I merged, but never pushed a new release. Will take care of that ASAP

from hiredis-rb.

Hey there! Did anyone managed to reproduce the issue described by @findchris since the latest release? Is it still open?

from hiredis-rb.

Bump - what is the status of this @badboy?

Should this be closes or is this still an issue?

from hiredis-rb.