Don't assume anything about localhost about automation-good-practices HOT 4 OPEN

Some consequences highlighted by a colleague (some are more generic though):

Avoid reading inventory files in scripts as they can contain variables
→ the script likely fails if you need the actual value
Lookups (file, template, ...) are executed on the ansible controller
→ if the playbook assumes ansible controller = provisioned host this leaves the customer with modifications to workaround this assumption
include_vars → same as lookups
Same for loading files in scripts - right now they are not on the ansible controller
Avoid modifying inventory files, ideally provide an ansible role and use set_facts
→ this also makes it more agnostic to the deployment scenario

from automation-good-practices.

a bit more context: this was something I mentioned for vendors providing "canned playbooks".
@ericzolf I can provide a bit content if this is simething that is deemed wothwhile to mention in this repo.

Just assign this to me in that case.

from automation-good-practices.

@jeichler @ericzolf I've noticed there hasn't been any update here in quite a while. What's the status?

from automation-good-practices.

no new status, but I can pick it up and send a PR soon-ish. @mophahr

from automation-good-practices.