Category filter button doesn't have a label so it is read out as "button" by text-to-speech about pride-london-app HOT 6 CLOSED

I've tested on Android and iOS and the following still needs to be done:

Tapping "Showing" should read out Showing
Tapping "All event types" should read out Filter by event type

Specific to iOS:
Tapping on the chevron should read out Filter by event type
On Android the chevron is treated as a separate button by the Voice tool, while it isn't on iOS. This isn't an issue until category types are selected.

With categories selected:

Tapping on the bar it should read out Filtering event type by x, y, z

from pride-london-app.

The button in question is the chevron part of Showing all event types

<- this

When you tap Showing it should say Showing
When you tap All Event Types it should say Filter by event type
When you tap the chevron it should say Filter by event type

In this state
When you tap the bar it should say Filtering by x, y, z...
When you tap the chevron it should say Filter by event type

from pride-london-app.

I can't figure out why when you tap Showing it reads Events instead - we haven't set it as a label anywhere! 🤔

from pride-london-app.

I have looked into adding the Filtering by x, y, z... label - it doesn't actually read that out instead of whichever category you picked. On the web I'd usually add some hidden text to be read out instead, but it doesn't look like that concept works on apps - you need to tap to read.

from pride-london-app.

The word "Showing" is read as "Events" because of the accessibilityLabel:

I agree that once a category was selected, the whole thing should read as "Filtering by x, y, z". We might be able to achieve this by giving the corresponding ScrollView (or a parent) an accessibilityLabel. Maybe we need to hide the children from screen readers additionally by using accessibilityElementsHidden.

In addition to this I wonder if the headline should contain the word "Events" somehow. E.g. "Showing events of all categories", "Showing events filtered by x, y, z" or "Events; showing all event types".

from pride-london-app.

Just to update, I have just merged #277. This is supposed to fix part of this issue. @declanslevin would you mind double checking and report back any further changes that you would like to see/hear?

from pride-london-app.