Comments (6)
I've tested on Android and iOS and the following still needs to be done:
Tapping "Showing" should read out Showing
Tapping "All event types" should read out Filter by event type
Specific to iOS:
Tapping on the chevron should read out Filter by event type
On Android the chevron is treated as a separate button by the Voice tool, while it isn't on iOS. This isn't an issue until category types are selected.
With categories selected:
Tapping on the bar it should read out Filtering event type by x, y, z
from pride-london-app.
The button in question is the chevron part of Showing all event types
<- this
When you tap Showing
it should say Showing
When you tap All Event Types
it should say Filter by event type
When you tap the chevron it should say Filter by event type
In this state
When you tap the bar it should say Filtering by x, y, z...
When you tap the chevron it should say Filter by event type
from pride-london-app.
I can't figure out why when you tap Showing
it reads Events
instead - we haven't set it as a label anywhere!
from pride-london-app.
I have looked into adding the Filtering by x, y, z...
label - it doesn't actually read that out instead of whichever category you picked. On the web I'd usually add some hidden text to be read out instead, but it doesn't look like that concept works on apps - you need to tap to read.
from pride-london-app.
The word "Showing" is read as "Events" because of the accessibilityLabel
:
I think this is wrong. I am not sure what is should read, though. Should it say "Showing" or maybe "Showing all event types"?
I agree that once a category was selected, the whole thing should read as "Filtering by x, y, z". We might be able to achieve this by giving the corresponding ScrollView (or a parent) an accessibilityLabel
. Maybe we need to hide the children from screen readers additionally by using accessibilityElementsHidden
.
In addition to this I wonder if the headline should contain the word "Events" somehow. E.g. "Showing events of all categories", "Showing events filtered by x, y, z" or "Events; showing all event types".
from pride-london-app.
Just to update, I have just merged #277. This is supposed to fix part of this issue. @declanslevin would you mind double checking and report back any further changes that you would like to see/hear?
from pride-london-app.
Related Issues (20)
- NSt3__112system_errorE in unknown method HOT 2
- java.lang.NoSuchMethodError in AirMapView.java:199
- java.lang.OutOfMemoryError in org.prideinlondon.festival.MainActivity
- java.lang.OutOfMemoryError in org.prideinlondon.festival.MainActivity
- java.lang.OutOfMemoryError in org.prideinlondon.festival.MainActivity
- java.lang.OutOfMemoryError in org.prideinlondon.festival.MainActivity
- java.lang.RuntimeException in org.prideinlondon.festival.MainActivity
- java.lang.StackOverflowError in ArrayList.java:552
- java.lang.IllegalArgumentException in org.prideinlondon.festival.MainActivity
- SIGABRT in folly::Expected<long long, folly::ConversionCode> folly::detail::str_to_integral<long long>(folly::Range<char const*>*)
- java.lang.IllegalArgumentException in com.sec.android.app.launcher.activities.LauncherActivity
- SIGABRT in RCTImageLoader
- java.lang.UnsatisfiedLinkError in Runtime.java:330
- Provide link in app to privacy policy
- HockeyApp to be demised November 2019
- Add Greenkeeper to project
- Upgrade React Native
- Align native project names
- Address Flow FixMe comments
- Fix e2e post React Native upgrade
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pride-london-app.