Missing access_token in extra_data about django-rest-framework-social-oauth2 HOT 7 CLOSED

I have a workaround for this issue which I'll detail below. I'm new to these libraries, so I'm having trouble figuring where the proper fix location would be. If anyone has an idea, let me know, I'm more than willing to fork, fix, test, and PR.

My current fix:
Inject a step into python-social-auth:

SOCIAL_AUTH_PIPELINE = (
    'social.pipeline.social_auth.social_details',
    'social.pipeline.social_auth.social_uid',
    'social.pipeline.social_auth.auth_allowed',
    'social.pipeline.social_auth.social_user',
    'social.pipeline.user.get_username',
    'social.pipeline.user.create_user',
    'social.pipeline.social_auth.associate_user',
    'path.to.your.view.save_oauth',
    'social.pipeline.social_auth.load_extra_data',
    'social.pipeline.user.user_details',
)

As this step occurs after associate_user, we have the newly created user model as well as the token available to us in the request.

@partial
def save_oauth(strategy, details, user=False, *args, **kwargs):
    request = kwargs.get('request', None)
    if user and request:
        access_token = request.get('token', None)
        social = user.social_auth.get(provider='github')
        social.extra_data['access_token'] = access_token
        social.save()
        return { 'is_new': False, 'user': user }
    return { 'is_new': True, 'user': None }

from django-rest-framework-social-oauth2.

This is not an issue actually. It comes from python-social-auth. Every backend has a different behavior and the user must modify the pipeline according to his needs. This is the expected behavior and this is exactly what you are doing :)

from django-rest-framework-social-oauth2.

The thing is....this wasn't a problem before. I was already using python-social-auth and it was saving the token on the user just fine.

It was only when I started using django-rest-framework-social-oauth2 that I had to manually set it as above.

from django-rest-framework-social-oauth2.

Well, I don't have time to investigate this as this is not blocking but if you find where this comes from tell me and I'll fix it.
You can begin here and follow here. See if the access token is present, if not track the starting point.

from django-rest-framework-social-oauth2.

Thats fine. Thanks for pointing me in the right direction. If I figure out the root of it, I'll open a PR with whichever project needs the fix.
At least for now there is relatively straightforward workaround.

from django-rest-framework-social-oauth2.

I've confirmed that this is an issue with python-social-auth. Given that it used to work for me, I assume it has to do with version number changes I made when I started using django-rest-framework-social-oauth2. Will continue to investigate and may open an issue with python-social-auth.

This ticket should be closed as far as I'm concerned.

from django-rest-framework-social-oauth2.

Thank you for your investigations.

from django-rest-framework-social-oauth2.