Any interest in being able to replace `react/createElement` with a custom function? about reagent HOT 7 OPEN

This is probably already possible with the Compiler protocol. make-element method is quite close to the createElement:
https://github.com/reagent-project/reagent/blob/master/src/reagent/impl/template.cljs#LL320C11-L320C11
https://github.com/reagent-project/reagent/blob/master/src/reagent/impl/template.cljs#L128-L141
https://github.com/reagent-project/reagent/blob/master/doc/ReagentCompiler.md

You might have to refer to some impl functions to reuse the code for other methods, so the API isn't perfect, but if you get it working I can consider exposing the necessary functions.

from reagent.

Checking your fork, there are few other createElement calls besides make-element but I'm quite sure that those don't matter, because the elements created in those cases refer to functions, not HTML elements, and they wouldn't use css.

from reagent.

Awesome, thanks for the feedback. I'll take a look at implementing it with the compiler

from reagent.

Have it working with the compiler here: cj-price@e09a8e6

I haven't tested the other places where react/createElement is used but for general use the compiler protocol seems more than enough to implement something like this.

Would you like me to clean up the example and submit a PR?

from reagent.

I guess Emotion is interesting enough to add a example to the repository.

The root package.json probably doesn't need to be changed?

The example should use shadow-cljs so it can use npm packages. There is an example in the material-ui folder.

The simple-example component seems unnecessary, as you can set the compiler directly on the render call. But perhaps it is for use from the intro ns now?

from reagent.

And a link could be added the compiler protocol docs to the example folder.

from reagent.

I submitted #593

I am using shadow-cljs as requested and removed the code from the intro. Also added a link on the docs. Willing to make any requested changes :)

The simple-example component seems unnecessary, as you can set the compiler directly on the render call. But perhaps it is for use from the intro ns now?

Yeah I did my testing on the intro which is why I rendered inside the simple example component.

from reagent.