conditional modal footer closes modal about reactstrap HOT 5 CLOSED

awesome! thanks @TheSharpieOne Your fix and thorough response actually made me lookup more info on event bubbling and capturing.

from reactstrap.

Thanks for reporting this issue and providing an example. It should work. I can see it's not. I'll need some time to dig into this or if anyone wants to look into this feel free to comment on here.

from reactstrap.

Figured it out... (took longer to figure out how to edit the webpackbin (my browser window was too small (less than 1280px wide) and I didn't realize the prevented me from editing and doing things...)
The button is removed from the DOM when there are no more files and this line states that if the thing that was clicked is not within the modal to go ahead and close it. Thus, anytime something is clicked in a modal and it triggers it to be removed from the modal, the modal will close.

A possible fix would be to set useCapture to true instead of false on the addEventListener. This should allow the modal to capture the event on the way down, before it triggers other handlers. I'll check this out when I get a chance to see if it works the way I think it will.

For now, a workaround would be to use styles to hide and show the remove button instead of adding it and removing it from the DOM or maybe even stopping the event (having your handler call stopPropagation() on the event).

from reactstrap.

Looks like it fixes the issue, tested locally. A PR is up for review.

from reactstrap.

Fix published in 3.0.1

from reactstrap.