Failed tests with OpenSSL 3 about socket HOT 5 CLOSED

Thanks for reporting @remicollet, it this also with the latest 1.10 release from a few hours ago?

from socket.

If I'm interpreting https://koji.fedoraproject.org/koji/taskinfo?taskID=79402997 and https://koji.fedoraproject.org/koji/taskinfo?taskID=79257205 correctly this was resolved in 1.10? (Seems that results on that just came in.)

from socket.

This report is about 1.9.0 and 1.10.0, build passes because this test is temporarily disabled for 1.10

from socket.

FYI /usr/bin/phpunit9 --bootstrap bootstrap.php --filter '^((?!(testConnectorUsesGivenResolverInstance|testConnectorUsesResolvedHostnameIfDnsIsUsed|testClientUsesTls10WhenCryptoMethodIsExplicitlyConfiguredByClient)).)*$' --exclude-group internet --verbose

I need to check testConnectorUsesGivenResolverInstance and testConnectorUsesResolvedHostnameIfDnsIsUsed, pêrhaps they need to be added in the "internet" group => PR #276

from socket.

@remicollet Thank you for reporting!

I can confirm this may indeed cause a test failure on some systems, but this should not affect normal usage of this library in any way.

The test in question explicitly creates a legacy TLS 1.0 connection, which by today's standards would be considered insecure. In fact, this would be prohibited on modern deployments (see MinProtocol = TLSv1.2 in openssl.conf).

The test already has a number of skip sections that check for specific error codes, but it looks like a dropped connection with no error is not among these checks at the moment.

It probably makes sense to refactor these tests to be more robust. I'll look into this when I can find some time, but happy to accept PRs if anybody wants to look into this before I get a chance! 👍

from socket.