Graceful shutdown of HttpClient about reactor-netty HOT 6 CLOSED

@akshaysu Currently:

1. If one uses the global LoopResources/ConnectionProvider, one can use reactor.netty.http.HttpResources#disposeLoopsAndConnections when it is appropriate because it will dispose these resources for the server and all clients that are currently running.

2. If one provides separate LoopResources/ConnectionProvider, again one knows better when those can be disposed. Reactor Netty doesn't have the knowledge whether LoopResources/ConnectionProvider are used only for the current server/client or they are shared amongst others.

Because of 1. and 2. there is no API for disposing LoopResources/ConnectionProvider on the level of server/client.
We can try to extend the documentation. Would you like to provide a PR with changes in the documentation?

from reactor-netty.

@violetagg thanks for the reply. Sorry, I'm new to the project reactor world. What do you mean by global LoopResources/ConnectionProvider? The one provided by the library when HttpClient.create() is called? Also, what happens when one uses ConnectionProivder.newConnection()? Do I need to dispose in this case?

from reactor-netty.

What do you mean by global LoopResources/ConnectionProvider? The one provided by the library when HttpClient.create() is called?

Yes HttpResources is used when HttpServer/HttpClient#create() is invoked.

Also, what happens when one uses ConnectionProivder.newConnection()

This is a ConnectionProvider that closes the connection after every request i.e. if you want to disable the connection pooling.

from reactor-netty.

@violetagg If I create 2 httpclients using HttpClient.create() are they going to share same LoopReosurces and ConnectionProviders? If I just provide ConnectionProvider like HttpClient.create(provider) what is the behaviour? Are there any reference document I can dig into?
My question on ConnectionProvider.newConnection() is that does this share same resources with other httpclients? and do I need to dispose for newConnection also?

I'm using HttpClient in Database Handler for remote api call. When database is closed I need to release HttpClient also

from reactor-netty.

@violetagg If I create 2 httpclients using HttpClient.create() are they going to share same LoopReosurces and ConnectionProviders?

Yes

If I just provide ConnectionProvider like HttpClient.create(provider) what is the behaviour?

This particular HttpClient will run with the provided ConnectionProvider.

Are there any reference document I can dig into?

Check this
https://projectreactor.io/docs/netty/release/reference/index.html#_connection_pool_2
and this
https://projectreactor.io/docs/netty/release/reference/index.html#_event_loop_group_2

My question on ConnectionProvider.newConnection() is that does this share same resources with other httpclients? and do I need to dispose for newConnection also?

The connection created by this special ConnectionProvider is never pooled and is closed after the request/response processing i.e. you do not use any connection pooling.

from reactor-netty.

@akshaysu I updated the reference documentation.

from reactor-netty.