Comments (2)
72f4cbd doesn't completely fix this (as subsequent invocations of onReadIdle
API depends on addHandler
, which went from failing on duplicate names to discarding the secondly added handler)... It makes the workaround shorter, though, with the addition of removeHandler
:
public void onReadInactivity(Runnable runnable, long inactivityDuration) {
// TODO: workaround for https://github.com/reactor/reactor-netty/issues/22
this.inbound.removeHandler(NettyPipeline.OnChannelReadIdle);
this.inbound.onReadIdle(inactivityDuration, runnable);
}
from reactor-netty.
I'm fine with suggested workaround but silently ignoring the second invocation doesn't seem fine. I would rather see an IllegalStateException pointing to the need to explicitly remove the existing handler first.
from reactor-netty.
Related Issues (20)
- ERROR io.netty.util.ResourceLeakDetector - LEAK: ByteBuf.release() was not called before it's garbage-collected. HOT 3
- HTTP2 Client doesn't work/DefaultChannelPipeline wrongly configure for HTTP2 HOT 2
- Connection reset by peer; nested exception is io.netty.channel.unix.Errors$NativeIoException: readAddress(..) HOT 2
- springcloud gateway netty pool config HOT 1
- LEAK: ByteBuf.release() was not called before it's garbage-collected. HOT 17
- ClassNotFoundException for HttpDecoderConfig using reactor-netty-http HOT 3
- Mutable NewConnectionProvider HOT 10
- ByteBuf LEAK when PoolAcquirePendingLimitException is thrown HOT 9
- Consistent Memory Increase in Webflux Application HOT 5
- Build should not depend on `doc:antora`
- Ongoing connection reset by peer HOT 6
- Memory Leak in reactor-netty when using Spring WebClient with blocked flux. Issue: Databuffer is not released. HOT 15
- IllegalArgumentException: Failed to parse a port from request HOT 2
- Wiremock proxy : Connection prematurely closed BEFORE response HOT 2
- Add ability to set idle-timeout for websockets HOT 3
- Micrometer Prometheus metrics export fails due to conditional `proxy.address` tag HOT 2
- Intermittent error with connection reset by peer. HOT 3
- recordServerConnectionInactive never invoked after WebSocket upgrade HOT 1
- Metrics not disposed for `GracefulShutdownInstrumentedPool` HOT 1
- non-blocking call delayed accasionally. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactor-netty.