Git Product home page Git Product logo

Comments (5)

chemicL avatar chemicL commented on June 6, 2024 1

Hey, @injae-kim 👋
I agree with you. It is super interesting that all the cases are "interesting". But it's not a failure per-se. So please go ahead and perhaps increase the loops from 100 to 1000 are willing to contribute :) Otherwise let me know, I'll handle it.

from reactor-core.

chemicL avatar chemicL commented on June 6, 2024 1

Actually, this happens constantly now with the configuration I introduced. I'll try to submit a PR for it, hope you don't mind.

from reactor-core.

injae-kim avatar injae-kim commented on June 6, 2024

assertThat(interesting).as("asserts racy cases").isLessThan(RACE_DETECTION_LOOPS);

// TO-BE
assertThat(interesting).as("asserts racy cases").isLessThanOrEqualTo(RACE_DETECTION_LOOPS);

How about using .isLessThanOrEqualTo(RACE_DETECTION_LOOPS) instead of isLessThan,
or increase RACE_DETECTION_LOOPS to decrease probability of All loops trigger race condition?

Cause this test failed when interesting(race condition count) is same with RACE_DETECTION_LOOPS (= it means All loops trigger race condition, it's really rare case but can be happen 😅)

from reactor-core.

injae-kim avatar injae-kim commented on June 6, 2024

oh~ I checked your awesome fix #3766 👍
thank you for agreeing with my opinion :) I happy that my investigation make sense!

from reactor-core.

chemicL avatar chemicL commented on June 6, 2024

As I said, I just applied your suggestions @injae-kim, thanks again for your help!

from reactor-core.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.