Comments (7)
Unfortunately, I old PR broke a couple of things in Sandpack. These changes introduced some edge cases and I hope this was the last one 🤞
from reactjs.org.
@danilowoz reverted the fix as it seemed to have broken all the sandpack instances in the site. This issue seems to have replicated the same that I reported here #6659 (comment). (sorry for the revert) cc: @rickhanlonii
from reactjs.org.
That was unexpected! For now, I'd try to fix the previous bug applying the following change
https://github.com/reactjs/react.dev/pull/6663/files#diff-8dd8662806ac667355c6bff8e8274df548eea48029d2c960160b7adb424501a4
I was able to reproduce it on Sandpack, but no idea what's causing that
from reactjs.org.
Thank you @danilowoz
Just to note that the sandpack for https://react.dev/learn/describing-the-ui#writing-markup-with-jsx
Shows the error the first time but not after scroll. Every other sandpack works correctly.
from reactjs.org.
@harish-sethuraman, there is still an issue on react.dev/learn/describing-the-ui#writing-markup-with-jsx. Can you confirm if this was introduced now?
Thanks @bondz, for reporting that
from reactjs.org.
I think it was introduced with this change. With 2.6.0
locally, it continues to show the Error message after the user scrolls away and back.
from reactjs.org.
In main I can see that the sandpack that @bondz has shared isnt working as expected. Shows blank screen occasionally.
have to confirm if this is affecting other sandpacks as well. From what I have seen it doesnt affect any other.
checked with older commits and seems like the preview takes time to load even after entering viewport and flickers. It didnt show loader rather when a preview (error) was already there it force replaced the preview again only after entering the viewport. Have attached the video from older commit without your changes (dan's commit) (url: https://react-1ctcjdyrh-fbopensource.vercel.app/)
Screen.Recording.2024-02-28.at.11.22.02.AM.mov
from reactjs.org.
Related Issues (20)
- Changement de numero de telephone HOT 1
- [Suggestion]: Section from useContext might not be entirely accurate
- Unpredicted behaviour in Online Code editor[Bug]:
- Hey
- [Bug]: "Referencing Values with Refs" ref illustration leads to sketchy site
- This page doesn’t exist. HOT 1
- [Suggestion]: Add some elaboration to the docs for TypeScript DOM events and Pure Functions
- ⚠Phishing Website Warning!!! There are phishing website links in the document. HOT 1
- [Bug]: photos in ref section of the tutorial are down
- [Suggestion]: shortcuts to localized sites?
- Not Found
- [Bug]: the hydrate-mismatch link seems not right HOT 4
- GENERATE_SOURCEMAP=false Issue HOT 1
- Worflow Automator Issues
- [Bug]: Excessive Requests for Page Data - Why Does This Happen?
- links to "use server" and "use client" docs are broken on directive page docs
- directives page is not found HOT 1
- 'use server' reference page does not exist in the doc HOT 1
- [Suggestion]: Add tsconfig.json update to React 19 upgrade guide HOT 8
- Use-server documentation URL broken HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactjs.org.