Git Product home page Git Product logo

Comments (13)

bennor avatar bennor commented on May 6, 2024

I've got one of these hanging around that I will add later today. I assume you meant ReSharper and not rebracer?

from refit.

clairernovotny avatar clairernovotny commented on May 6, 2024

No, I meant rebracer, though R# works too.
https://visualstudiogallery.msdn.microsoft.com/410e9b9f-65f3-4495-b68e-15567e543c58

from refit.

clairernovotny avatar clairernovotny commented on May 6, 2024

I will never like the java/javascript brace style :P

from refit.

bennor avatar bennor commented on May 6, 2024

Never heard of rebracer. Will check it out.

from refit.

clairernovotny avatar clairernovotny commented on May 6, 2024

Yeah, it's a bit more targeted than R# and it's free, so it's more likely to get people to abide by it. Just install the VSIX and go.

from refit.

anaisbetts avatar anaisbetts commented on May 6, 2024

from refit.

clairernovotny avatar clairernovotny commented on May 6, 2024

@paulcbetts 👍

from refit.

bennor avatar bennor commented on May 6, 2024

Cool. Will sort them both out soon. 😸

from refit.

anaisbetts avatar anaisbetts commented on May 6, 2024

@bennor Steal them from ReactiveUI

from refit.

bennor avatar bennor commented on May 6, 2024

👍 easy

from refit.

bennor avatar bennor commented on May 6, 2024

Okay, so not quite as easy as I'd hoped. There's no Rebracer.xml in RxUI, and the R# settings seem to be a fair bit different to the ones I had created.

I created mine by messing with R# options and formatting RequestBuilderImplementation.cs until there were no visible changes to the file after formatting, so I'm pretty sure it's good. (It has a few things that are missing from the RxUI one -- like catch blocks being on the same line, etc.)

I'll create a PR with the files in a few minutes.

from refit.

clairernovotny avatar clairernovotny commented on May 6, 2024

The R# ones look good, except for missing the Add Braces for an if block if they're not already there.

The rebracer ones don't seem to work; Edit->Format document gives me different results. Maybe the Rebracer just isn't worth the hassle?

from refit.

bennor avatar bennor commented on May 6, 2024

The R# one should be forcing braces for multi-line but hoisting single line if statements up to the same line, which was the convention Paul seemed to o be using. I did this all by guesswork and comparison to existing code, so it's entirely possible there are some gaps.

I wonder why the rebracer file doesn't work? The R# one is more comprehensive but both of them still have some small differences. There are some things in the existing code that aren't consistent with each other (like spaces after an if keyword), so for those I just tried to match whatever was more common.

from refit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.