[Bug]: Visual Studio hot reload broken about reactiveui HOT 21 CLOSED

FYI: I made a post about it on the VS developer community

https://developercommunity.visualstudio.com/t/SystemReactive-breaks-hot-reload-in-VS/10522361?sort=newest&q=hot+reload

from reactiveui.

@christosk92 @glennawatson this bug appears fixed, I've just updated to vs 17.9 preview 5 and no longer experiencing this bug

from reactiveui.

We are working on a new release soon so see if that resolves your issues

from reactiveui.

There is also similar problems with ASP.net, Console projects and VS2022 17.8, but no inclusion of ReactiveUI. I will try to debug the root cause and see if there's anything in ReactiveUI that is specifically causing the issue. From my projects the common factor is System.Reactive, either way hopefully I'll locate the issue.

from reactiveui.

We are working on a new release soon so see if that resolves your issues

Thanks for your reply.

In the meantime I will see if falling back to a previous version of VS resolves this issue.

from reactiveui.

@glennawatson I was able to clone the Main branch of this repository and reference it in my app.
I can confirm this does indeed seem to fix the problem. Looking forward to an official release. Thanks !

from reactiveui.

Thanks. Be sometime this week. I got one optimisation I want to do before release.

from reactiveui.

@glennawatson Eh... I think I spoke to soon. It seems that there were some incremental build shenanigans. After a full clean/rebuild the issue is back again. I have the source code running now so I might have a look at it to see what's wrong. I wasn't able to downgrade my Visual Studio (I have no idea how). Do you have any ideas perhaps why this issue might occur?

from reactiveui.

My apologies, i had some internet issues while reopening the question.

from reactiveui.

Can you produce a minimum sample that causes the issue for you.

from reactiveui.

Well it happens with any new WinAppSdk project.

The basic steps are; using the latest visual studio:

1. Create a C# WinUI with WindowsAppSdk app (not .NET Maui but actually native Windows)
2. Run the app, observe hot reload working properly.
3. Add the ReactiveUI.WinUI package to the project.
4. clean and rebuild project.
5. Observe hot reload not working anymore.

A video:
https://streamable.com/u93oq9

Streamable

2023-11-19 22-30-08

Watch "2023-11-19 22-30-08" on Streamable.

from reactiveui.

I just want to add I have similar issues, but with xaml. As soon as I add ReactiveUI as a nuget package then edit some xaml I get the following errors.

The types of errors are:
The specified value cannot be assigned to the collection. The following type was expected "UIElement"
The attached property "Column" can only be applied to types that derive from "UIElement"
The member "Spacing" is not recognized or is not accessible

The errors are generated when the xaml is edited at run time and appears to prevent xaml hot reload from working.

from reactiveui.

Exactly the same issue for me too.

from reactiveui.

Looks like this happened when I upgraded to 17.8

from reactiveui.

I actually managed to downgrade to Visual Studio 17.6 using https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-history#release-dates-and-build-numbers

I can confirm that hot reload does indeed work with ReactiveUI. So it does seem like it's a regression from Visual Studio. Should we just close this issue here and report it to the vs community?

Visual Studio 2022 Release History

A list of released versions, build numbers, and release links for Visual Studio 2022.

from reactiveui.

Lets leave it open until VS2022 17.8.xxx is fixed, just for visibility for others.
This should avoid others raising the same issue.
Thank you.

from reactiveui.

FYI - this same issue appears to happen when using CommunityToolkit as well. I'm not using ReactiveUI, but I get the same lack of hot reload and the "errors" that @SoggyBottomBoy screenshotted.

You have to laugh to keep from crying. Windows App development is so miserably terrible that all these frameworks exist to make it less miserable. But you use the frameworks and VS breaks. Can't win.

from reactiveui.

Yeah little bit hard for us this one if it's a legitimate failure by visual studio. We can probably reach out to the teams if we get a decent repo. No guarantees tho

from reactiveui.

Microsoft is getting very close to anti trust territory like the early 2000's.

from reactiveui.

@christosk92 @glennawatson this bug appears fixed, I've just updated to vs 17.9 preview 5 and no longer experiencing this bug

Thank you for your feedback, glad the VS team finally got round to fixing it.

from reactiveui.

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from reactiveui.