Comments (8)
@Kavignon What @glennawatson is most likely pointing out is that the sample is old. ReactiveUI has a healthy release cadence. There is the potential that the sample no longer works with/targets the current version of the framework. Which would indicate that there have potentially been breaking changes since this sample was created. So the "maintenance burden" he is referring to is keeping the samples relevant given the release cadence.
Given that there is still a packages.config
that points to older framework versions, I would wager that's what he's referring to.
from reactiveui.samples.
Hey @Kavignon 👋,
Thank you for opening an issue. We will get back to you as soon as we can. Also, check out our Open Collective and consider contributing financially.
https://opencollective.com/reactiveui
PS.: We offer
priority
support for all financial contributors. Don't forget to addpriority
label once you start contributing 😄
An advanced, composable, functional reactive model-view-viewmodel framework for all .NET platforms!
from reactiveui.samples.
There is a bit of a maintenance burden so ideally if you get the samples up and running you'll have them working in the sln file.
from reactiveui.samples.
Are you saying that the samples are broken? @glennawatson
from reactiveui.samples.
@RLittlesII Ok I see! I'm not that familiar with .NET Core, package.config isn't suppose to be found any more?
I'm guessing here, my PR should remove the maintenance issue and make sure those samples are brought up to date with the current APIs?
from reactiveui.samples.
They replaced the packed.config with PackageReference.
Just a lot cleaner since it handles dependency packages.
from reactiveui.samples.
@Kavignon I would think that satisfying this issue would be to either create a new sample, or bring the old sample up to date.
I'd assume a potential task list of:
- Update to the current version of ReactiveUI
- Resolve any compilation issues
- This will most likely be easier moving to
PackageReference
- This will most likely be easier moving to
- Build and execute the sample
- Verify the samples functionality works as expected
Yes. In the .NET Core space packages.config
has been replaced with PackageReference
in the .csproj file. I can tell the sample is old because of the existence of the file, and the references to Rx 2.2.5. The current version of System.Reactive
is 4.1.6
More on Migrating to PackageReference
from reactiveui.samples.
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
from reactiveui.samples.
Related Issues (20)
- Add better blazor samples HOT 2
- Request for Generic Host (.NET Core 3) + Prism + WPF sample - Can contribute HOT 2
- [BUG] Uno Samples Don't Load In Visual Studio HOT 1
- [BUG] Update Xamarin Forms Samples to work with latest Xamarin HOT 4
- sample of wpf in .net5 HOT 1
- ReactiveDemo for WPF throws Null exception HOT 1
- feature: More advanced Blazor examples HOT 1
- feature: Title HOT 2
- [BUG] ReactiveUI.Samples.Commands example not showing how to bind command CanExecute property
- [BUG] Commands names violates documented convention
- ASP MVC Core Sample for widget with graph
- [BUG] ReactiveUI.Samples.Routing101 does not compile HOT 1
- WinForms example update to .net Core 6 and latest C# functionality HOT 2
- WinForms - new demo project HOT 3
- [BUG] demo is not work HOT 12
- [BUG] Sample code from Handbook is not working HOT 1
- Please add a simple loading label while NuGet records are retrieved
- Poor Developer Experience Arising from Single Solution Across All Samples HOT 3
- Dependency Dashboard
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactiveui.samples.