Comments (4)
mjohnson541
commented on June 15, 2024
This is happening because it's using bsol.domain.T when it should use the more general getT(bsol,t)
from reactionmechanismsimulator.jl.
kspieks
commented on June 15, 2024
Are both errors are happening because of this? If so, I can submit a quick PR that changes bsol.domain.T to getT(bsol,t)
from reactionmechanismsimulator.jl.
mjohnson541
commented on June 15, 2024
Sorry, that's the issue with (2). I don't know why (2) works, but (1) doesn't.
from reactionmechanismsimulator.jl.
kspieks
commented on June 15, 2024
Okay yea I was just curious. I was testing out both options, though I'll only use 2) when making the adapter. I'll try changing it to getT(bsol,t) and running it again. If it works, I'll submit a PR. Thanks :)
from reactionmechanismsimulator.jl.
Related Issues (20)
- Unsatisfiable requirements during the installation HOT 1
- DiffEqSensitivity -> SciMLSensitivity
- Remove Static Array Use
- Flexible Constructors for Species and Reactions
- Fragment array functions in Simulation.jl are overwriting other helper functions HOT 2
- ParametrizedTConstantVDomain must take "T" as a function or if an array of times for "ts" is supplied as an array of volumes HOT 7
- Fix documentation HOT 4
- No sensitivity for interface reactions HOT 9
- Reduce Amount of Log Output HOT 1
- rmgmolecule: supported python version HOT 2
- adjoint sensitivity analysis broken in recent builds HOT 1
- RMS input from list of reactions with given rate constants?
- [Feature] Add a `load` function
- Release a new version?
- Add a load function to reconstruct ODESolution object from csv file
- A native RMS Chemkin reader
- Add Mechanism Debugging tools to documentation
- Cannot install RMS due to Julia update
- Additional Unit Tests HOT 1
- Installation issues rmgmolecule HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from reactionmechanismsimulator.jl.