needs initial API implementation discussion about example-payments-plugin HOT 3 OPEN

I had a thought regarding this. We could make a single @reactioncommerce/meteor-deps package that exports provideDeps and withDeps functions.

In Reaction codebase somewhere:

import { provideDeps } from "@reactioncommerce/meteor-deps";

provideDeps({
  check,
  Tracker,
  // etc.
});

And every NPM package that needs deps would have a peer dependency on @reactioncommerce/meteor-deps and do:

import { withDeps } from "@reactioncommerce/meteor-deps";

withDeps(({
  check,
  Tracker,
  // etc.
}) => {
  // initialize the package
});

The meteor-deps package would just be this:

let deps = {};
let hasDeps = false;
let funcs = [];

export function withDeps(func) {
  if (hasDeps) {
    func(deps);
  } else {
    funcs.push(func);
  }
}

export function provideDeps(userDeps) {
  deps = { ...userDeps };
  funcs.forEach((func) => func(deps));
  funcs = [];
  hasDeps = true;
}

The benefit here is that you'll be able to simply npm install any plugin package and won't need to add any code to make it work. As long as provideDeps is being called with all the deps that all plugins need.

from example-payments-plugin.

@jshimko Great writeup.

This seems like an excellent approach similar to what you and I had talked about. If we get signoff from @spencern should we be able to move forward with building this?

from example-payments-plugin.

Good approach @jshimko and I like the suggestion made by @aldeed as well.

This makes sense as a template for migrating plugins to npm, and I think we should probably get on the same page in terms of our priorities for what packages should be migrated first.

from example-payments-plugin.