Git Product home page Git Product logo

Comments (5)

saghul avatar saghul commented on June 27, 2024

Can you please make a more reduced example?

from react-native-webrtc.

bagusaff avatar bagusaff commented on June 27, 2024

Can you please make a more reduced example?

Hi, really appreciate your fast response! I have updated & reduced my code example.

from react-native-webrtc.

saghul avatar saghul commented on June 27, 2024
    const handleRemoteOffer = async (offer: any) => {
      if (!localPC) {
        await setupPeerConnection();
      }
      await localPC.setRemoteDescription(new RTCSessionDescription(offer));
      const answer = await localPC.createAnswer();
      await localPC.setLocalDescription(answer);

      socket.current?.send(
        JSON.stringify({type: 'answer', answer, roomId: roomIdToJoin}),
      );

      if (remoteCandidates.length > 1) {
        for (let candidate of remoteCandidates) {
          handleRemoteICECandidate(candidate);
        }
        remoteCandidates = [];
      }
    };

Not sure if this is it, but if you end up calling setupPeerConnection here things will break because you are attempting to set a remote offer while having a local offer.

from react-native-webrtc.

bagusaff avatar bagusaff commented on June 27, 2024
```js
    const handleRemoteOffer = async (offer: any) => {
      if (!localPC) {
        await setupPeerConnection();
      }
      await localPC.setRemoteDescription(new RTCSessionDescription(offer));
      const answer = await localPC.createAnswer();
      await localPC.setLocalDescription(answer);

      socket.current?.send(
        JSON.stringify({type: 'answer', answer, roomId: roomIdToJoin}),
      );

      if (remoteCandidates.length > 1) {
        for (let candidate of remoteCandidates) {
          handleRemoteICECandidate(candidate);
        }
        remoteCandidates = [];
      }
    };

Not sure if this is it, but if you end up calling setupPeerConnection here things will break because you are attempting to set a remote offer while having a local offer.

Thanks for the insight! It was actually my most recently added code while I tried to fix the issue, which means that the issue happens even before I added that line :"))

from react-native-webrtc.

bagusaff avatar bagusaff commented on June 27, 2024
case 'candidate':
            if (!localPC || !localPC.remoteDescription?.type) {
              console.log(
                'Cant find peerconnection, adding candidates to queue',
              );
remoteCandidates.push(data?.candidate);
            } else {
              handleRemoteICECandidate(data?.candidate);
            }
            break;

I dont know if this information is important, but If I tried to handleRemoteICE with this method it will resulted to error :

Error adding received ice candidate [Error: The remote description was null]

from react-native-webrtc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.