Git Product home page Git Product logo

Comments (16)

KDederichs avatar KDederichs commented on May 20, 2024 2

OK....
Turns out I picked up some brew package that installed gflags causing the pod to be installed as enabled with it.
After removing the brew version of gflags it works again.

Question now is it that a bug I should mention in the main repo or is it an intended feature?

from upgrade-support.

rickhanlonii avatar rickhanlonii commented on May 20, 2024 2

cc @alloy @passy

from upgrade-support.

passy avatar passy commented on May 20, 2024 1

cc @priteshrnandgaonkar

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024 1

@alloy it's not only flipper, the normal RN glog does the same thing

from upgrade-support.

lucasbento avatar lucasbento commented on May 20, 2024

@KDederichs can you please provide a minimal project to reproduce your issue? Without that it is very difficult to help you out.

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024

I'm not quite sure how I'd go about that tbh.
Since I assume it's something specifically missing in my project I have no good way of reproducing it since I don't know what's missing.

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024

Actually it does that on a fresh project too @lucasbento
Just did fresh app to see if that works and it's the same problem

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024

In fact everything I do now results in that....
Even checking out the branch that's still on 0.61.5

from upgrade-support.

lucasbento avatar lucasbento commented on May 20, 2024

@KDederichs which CocoaPods version are you using? you can check that by running pod --version

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024

@lucasbento Version 1.9.1

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024

I already tried:

Cleaning the Xcode build
Deleting Xcode DerivedData
Deleting the Pods folder
Deleting the Pods cache
Deleting node_modules
Switching between legacy and new build system

result is always the same:
/ios/Pods/glog/src/glog/logging.h:86:10: fatal error: 'gflags/gflags.h' file not found

from upgrade-support.

pvinis avatar pvinis commented on May 20, 2024

What does your Podfile and Podfile.lock look like?

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024

@pvinis

Podfile:

platform :ios, '9.0'
require_relative '../node_modules/@react-native-community/cli-platform-ios/native_modules'

def add_flipper_pods!
  version = '~> 0.33.1'
  pod 'FlipperKit', version, :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitLayoutPlugin', version, :configuration => 'Debug'
  pod 'FlipperKit/SKIOSNetworkPlugin', version, :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitUserDefaultsPlugin', version, :configuration => 'Debug'
  pod 'FlipperKit/FlipperKitReactPlugin', version, :configuration => 'Debug'
end

# Post Install processing for Flipper
def flipper_post_install(installer)
  installer.pods_project.targets.each do |target|
    if target.name == 'YogaKit'
      target.build_configurations.each do |config|
        config.build_settings['SWIFT_VERSION'] = '4.1'
      end
    end
  end
end

target 'PROJECT_NAME' do
  # Pods for PROJECT_NAME
  pod 'FBLazyVector', :path => "../node_modules/react-native/Libraries/FBLazyVector"
  pod 'FBReactNativeSpec', :path => "../node_modules/react-native/Libraries/FBReactNativeSpec"
  pod 'RCTRequired', :path => "../node_modules/react-native/Libraries/RCTRequired"
  pod 'RCTTypeSafety', :path => "../node_modules/react-native/Libraries/TypeSafety"
  pod 'React', :path => '../node_modules/react-native/'
  pod 'React-Core', :path => '../node_modules/react-native/'
  pod 'React-CoreModules', :path => '../node_modules/react-native/React/CoreModules'
  pod 'React-Core/DevSupport', :path => '../node_modules/react-native/'
  pod 'React-RCTActionSheet', :path => '../node_modules/react-native/Libraries/ActionSheetIOS'
  pod 'React-RCTAnimation', :path => '../node_modules/react-native/Libraries/NativeAnimation'
  pod 'React-RCTBlob', :path => '../node_modules/react-native/Libraries/Blob'
  pod 'React-RCTImage', :path => '../node_modules/react-native/Libraries/Image'
  pod 'React-RCTLinking', :path => '../node_modules/react-native/Libraries/LinkingIOS'
  pod 'React-RCTNetwork', :path => '../node_modules/react-native/Libraries/Network'
  pod 'React-RCTSettings', :path => '../node_modules/react-native/Libraries/Settings'
  pod 'React-RCTText', :path => '../node_modules/react-native/Libraries/Text'
  pod 'React-RCTVibration', :path => '../node_modules/react-native/Libraries/Vibration'
  pod 'React-Core/RCTWebSocket', :path => '../node_modules/react-native/'

  pod 'React-cxxreact', :path => '../node_modules/react-native/ReactCommon/cxxreact'
  pod 'React-jsi', :path => '../node_modules/react-native/ReactCommon/jsi'
  pod 'React-jsiexecutor', :path => '../node_modules/react-native/ReactCommon/jsiexecutor'
  pod 'React-jsinspector', :path => '../node_modules/react-native/ReactCommon/jsinspector'
  pod 'ReactCommon/callinvoker', :path => "../node_modules/react-native/ReactCommon"
  pod 'ReactCommon/turbomodule/core', :path => "../node_modules/react-native/ReactCommon"
  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga', :modular_headers => true

  pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
  pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/glog.podspec'
  pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'

  use_native_modules!

  # Enables Flipper.
  #
  # Note that if you have use_frameworks! enabled, Flipper will not work and
  # you should disable these next few lines.
  add_flipper_pods!
  post_install do |installer|
    flipper_post_install(installer)
  end
end

Podfile.lock:
https://pastebin.com/awiNQV2b

That's after the 62 update, before that just the same minus the flipper stuff and the Yoga and callinvoker change

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024

I think it might not execute the iOS-install-third-party.sh script if that helps.
Don't know if it's supposed to execute that during builds

from upgrade-support.

alloy avatar alloy commented on May 20, 2024

The Flipper-Glog.podspec uses an external configure script. I suspect that script is picking up the availability of gflags for macOS when it shouldn’t.

Question now is it that a bug I should mention in the main repo or is it an intended feature?

@KDederichs I would classify this as a bug in the Flipper repo.

from upgrade-support.

KDederichs avatar KDederichs commented on May 20, 2024

In any case I opened an issue over at facebook/react-native#28446 so I'll be closing this issue now, thanks for everyone that tried to help!

from upgrade-support.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.