--mode vs (deprecated) --variant flag - clarity required about cli HOT 8 CLOSED

Thanks folks, will get a PR up later this week and ping you both

from cli.

hey @aljidy, I think we can update docs to also cover in --mode's description that it can accept buildVariant. Do you mind sending PR updating this? 🙏

from cli.

I feel we should be able to remove --variant entirely at this point?

from cli.

@cortinico it's removed already.

from cli.

Oh from the docs as well?

from cli.

Yup.

from cli.

I used the original value of the variant parameter to pass into mode, and I found that the error message indicates a dependency content could not be found.

Like:

android/app/src/debug/java/cn/demo/app/ReactNativeFlipper.java:10: error: package com.facebook.flipper.android does not exist
import com.facebook.flipper.android.AndroidFlipperClient;

Did I use it in wrong way?

from cli.

hey @zfben, your error is not related to this issue. If the problem still occurs please create new issue with the related description and reproduction steps.

from cli.