Dragging SVG elements in IE (any version) about react-draggable HOT 13 CLOSED

I can confirm this issue. It is a known bug in IE.

A fix would require detecting if a node is an Instance of SVGElement and using the transform attribute; not the style transform property. If I find some spare time I'll try to write a patch.

from react-draggable.

@petesaia Haven't had a chance to write tests and put in a pull request but I have fix here - https://github.com/martinRoss/react-draggable

I was hoping to intelligently detect if the child nodes were of type SVGElement but it does not look like there is a reliable way to do that; particularlly when an SVG is created without a namespace. Instead, you'll have to set isSVG={true} if you are using this with an SVG element. Chrome and Firefox respect the transform property so this shouldn't break anything for you.

from react-draggable.

Man, that's awesome. Thanks a lot @martinRoss!

from react-draggable.

Would be great to get this merged.

from react-draggable.

I guess the main issue is that it can't be used simple by adding

"react-bootstrap": "https://github.com/mzabriskie/react-draggable.git"

to the package.

from react-draggable.

@petesaia Just wrote some tests and submitted a pull request. Hopefully this will make it into master soon!

from react-draggable.

I hope so too @martinRoss! Thanks again, really.

from react-draggable.

Is there anything else I can do to move this along? Sorry, i'm on a project that's sort of pressing. Perhaps share the fix?

from react-draggable.

@petesaia I found a way to autodetect this instead of using a prop (the original pull request). I will try to write tests tonight and put in a new pull request. If it doesn't get merged soon I can work with you to get it working on your project.

from react-draggable.

@martinRoss Thanks, I would appreciate the PR.

from react-draggable.

@STRML I just put in a new pull request (now internally detecting if an element is an instanceof SVGElement) Let me know if there's anything else I can do!

from react-draggable.

Fixed in 0.8.4, thanks @martinRoss .

from react-draggable.

Glad to help.

On Thu, Oct 15, 2015 at 4:15 PM Samuel Reed [email protected]
wrote:

Fixed in 0.8.4, thanks @martinRoss https://github.com/martinRoss .

—
Reply to this email directly or view it on GitHub
#83 (comment)
.

from react-draggable.