Consider changing bsVariation props about react-bootstrap HOT 4 CLOSED

It seems that this breaks the convention for the rest of the attributes, bsStyle etc. I think that being explicit in the declaration of a bootstrap type is a good thing, especially for others who aren't as familiar with the code.

from react-bootstrap.

@stevie-mayhew the variation property is a bit of a weird one and not really well defined like the bsStyle or bsSize as such i'm not really sure the suggested change breaks any necessary convention.

I think it makes sense to add these as boolean properties since the bsVariation prop doesn't really add any more information as to what the property does it seems pointless to keep it.

from react-bootstrap.

I'm just wary of introducing inconsistent ways to handle similar mutating transforms.

from react-bootstrap.

Yeah, it's decided - bsVariation doesn't make sense, let's kill it with fire.

from react-bootstrap.