Comments (9)
Yeah, thing is that you don't publish anything to Bower, it just gets the package from Github. We could have separate projects for the source and build?
from react-bootstrap.
That would work actually - a repo each for AMD + CommonJS + another for the source. I'll look into doing that.
from react-bootstrap.
Yeah sounds good having a separate repo for Bower, heres the react
one for referance: https://github.com/facebook/react-bower
I wonder if it would be worth looking into using a UMD wrapper for the modules so we don't need the extra duplication of both AMD and CommonJS dirs, we could add this as a build step. React are looking to use pure-cjs for this facebook/react#1002
from react-bootstrap.
I'm not sure pure-cjs fits the bill. It seems to only wrap the top level module in UMD which wouldn't let you require specific components. I think its fine as it is if we add react-bootstrap-bower
and react-bootstrap-npm
repos.
Probably worth doing it at the same time as moving to an org as you have to write a nice letter to the Bower people to get them to move the package. What was that react component org you mentioned before?
from react-bootstrap.
Right yeah i thought might be the case, would you still include the cjs
and amd
dirs in both packages?
The react org is: https://github.com/reactjs.
Wow the bower people still haven't fixed that, guess that makes sense then.
from react-bootstrap.
No, I'd only include the built files for that module system in the root of the repo so no more amd
and cjs
dirs
from react-bootstrap.
Have published built packages for npm and bower at https://github.com/react-bootstrap
Will have to wait for Bower to update their db before removing the built files from here bower/bower#120
from react-bootstrap.
Nice work!
from react-bootstrap.
Right have got fed up waiting for Bower and removed the built files from here. They are now at https://github.com/react-bootstrap
from react-bootstrap.
Related Issues (20)
- Bug - Page Not Found for Tabs Doc Site HOT 3
- Dropdown should overlay the parent container HOT 1
- Alignment of button text in grid changes if href tag is set HOT 1
- Feature Request: Custom Anchor element for PageItem
- Button is not responsive inside the MODAL HOT 3
- defaultActiveKey and alwaysOpen not working properly at the same time HOT 1
- Error using components HOT 1
- NextJS <Link> giving error with react-bootstrap <Navbar.Link> HOT 1
- Docs - Components props tables are missing
- Tabs Component doesn't pass id attribute to underlying element HOT 1
- aria-label for DropdownButton HOT 2
- React Bootstrap doesn't let me set background color HOT 1
- Bug: OverlayTrigger doesn't hide after modal close. HOT 5
- Rendering children (Accordion) HOT 1
- Modal component stop working when closed HOT 6
- Keyboard input Tab + Shift escapes Modal's focus HOT 3
- ESC and Up/Down in Dropdown doesn't work when using the native Bootstrap HOT 2
- Suggest adding 'use clientโ for all the react-bootstrap component HOT 4
- Question: How to enable right-to-left (RTL) while using bootstrap SCSS instead of CSS to customize styles HOT 1
- EventKey in callback function onSelect of Tabs component does not match type of EventKey given to an individual Tab component HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-bootstrap.