Passing in additional classes about react-bootstrap HOT 10 CLOSED

Sorry, I stand corrected. Button is absolutely fine, but the Panel doesn't use transferPropsTo.

from react-bootstrap.

A bug I would say. I think Panel, DropdownButton and SplitButton should all use transferPropsTo. DropdownButton and SplitButton should also explicitly set the title prop to null to stop this being passed to the DOM element.

PR greatly appreciated!

from react-bootstrap.

Let me see if I can do that tonight.

from react-bootstrap.

Does Nav also suffer from this? Adding className="navbar-right" does not add the new class.

from react-bootstrap.

I think the Nav one is a separate issue, it does have transferToProps set but the transferToProps passes the navbar-right class to the wrong element, the top level nav rather than the ul where the other nav classes are set.
I think the navbar-right class should really be set-able via a prop on the Nav component.

PR for this would also be greatly appreciated!

from react-bootstrap.

I believe this issue has been resolved via #104, #105, #107.

Feel free to re-open if thats not the case.

from react-bootstrap.

I think the issue still exists for the Nav component:

var Header = React.createClass({
    render: function()
    {
        return (
            <div id="header">
                <Navbar>
                    <NavBrand>cocorico</NavBrand>
                    <Nav className="pull-right">
                        <NavItem eventKey={1} href="#">Link</NavItem>
                        <NavItem eventKey={2} href="#">Link</NavItem>
                    </Nav>
                </Navbar>
            </div>
        );
    }
});

doesn't work as expected.

from react-bootstrap.

Nav's classes apply to the <nav>, not the <ul>. Use the pullRight prop there.

from react-bootstrap.

And next time check the docs first - this is all clearly shown there.

from react-bootstrap.

<NavDropdown title="Dropdown" id="collasible-nav-dropdown">
        <NavDropdown.Item href="#action/3.1">Action</NavDropdown.Item>
</NavDropdown>

The NavDropdown create a div element and inside that element create a link tag with the following properties:
<a aria-haspopup="true" aria-expanded="false" href="#" class="dropdown-toggle nav-link" role="button">Dropdown</a>
How do I add a Font Awesome icon and a span tag instead of the text, also how do I add more classes to the link tag additional to the "dropdown-toggle nav-link" classes?

from react-bootstrap.