Comments (4)
Hey @im-bob-loucans
Rollup is not enforced in any way, it was probably chosen as bundler from the options available at the moment. So far we have not experienced many problems with bundling our apps or Lightning itself but that may be because we are not using bundlers extensively.
I can't tell what the result of aggressive name mangling will be, but ES6 to ES5 transpilation and minification should at the very least work.
If there are any issues with Lightning when used in conjunction with e.g. Webpack, this is something we can look into.
from lightning.
Thanks for reply.
I turned on minification using both rollup and webpack tools - in both cases the the app stopped working. I believe I tracked this down to changes class and function names. In particular I think the state machine requires the name of the state class and the names used in _setState methods to be the match. Also, there is specific string matching done to call the $enter and $exit methods. To correct I did this -
Rollup:
plugins: [
...,
terser.terser({
keep_classnames: true,
keep_fnames: true,
sourcemap: false,
}),
...,
],
Webpack:
...
optimization: {
minimize: true,
minimizer: [
new TerserPlugin({
terserOptions: {
keep_classnames: true,
keep_fnames: true
}
})
]
},
...
Perhaps you could add a documentation section on using use with bundlers and packaging.
from lightning.
@g-zachar is there any updates to provide documentation section on using with bundles and packaging? It would be great to get configs for webpack with transformation es6 to es5.
from lightning.
Hey @MykhailoDz
This matter is still to be addressed, we have several dependencies that prevent us from moving forward with this one and we need to tackle them first.
Best regards
from lightning.
Related Issues (20)
- Regression with advanced text renderer and line height. HOT 1
- Regression with rendering text that uses normal spaces HOT 3
- Tree shaking HOT 3
- Unable to run lightning on QT5 browser HOT 3
- Bind attempt of recently deleted buffers and textures
- Alpha channel heuristic when not using ImageWorker doesn't deal with uppercase file extensions HOT 6
- Unnecessary allocations per frame HOT 3
- Enable to use webgl2 when webgl is not enabled in device. HOT 2
- Calling `chidlList.add` to add an element that's already in the childList throws "out of bounds" error
- Issue with dynamic width and height HOT 4
- Font renderer smoothness issues on EOS STBs HOT 1
- Duplicate call for `_cleanupLookupMap`
- Draw function crashing because of undefined texture
- Version 2.12.1 not including typescript types HOT 4
- Double texture freeing bug
- Text Truncated with advancedRenderer but Ellipsis Included in New Line
- Wrong calculation for `getRoundRect` stroke width HOT 2
- Lightning Core > 2.11.0 Unsupported on older browsers HOT 2
- Unable to use `monospace` system font HOT 1
- Arabic Text with English Numbers Not Rendering Correctly in RTL Format
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lightning.