query type detection does not work with non-newline queries about sparqlwrapper HOT 4 CLOSED

This might do the trick (to remove single line comments):

re.compile(r"""
    # leading whitespace
    \s*
    # bits of query
    (?P<query_parts>(
        # IRI
        <.*?>|
        # quoted strings (using single or double quotes, in triplicate)
        (?P<quotes>("{3}|'{3}))(.|\n)*?(?P=quotes)|
        # quoted strings (using single or double quotes, individual)
        (?P<lquotes>["']).*?(?P=lquotes)|
        # everything except starts for the above two, whitespace and comment
        [^<"'\#\s]+|
        # whitespace (except newline) if not followed by comment, newline (or end of query)
        [^\S\n]+(?![^\S\n]*(\#|\n|$))|
        # escaped hashes
        (?<=\\)\#
    # bits of query can have zero or more elements
    )*)
    # comment and preceeding whitespace (up to next newline, if present)
    (\s*\#[^\n]*)?""", re.X)

(It might not be necessary to check whether the whole match starts & ends with newline - I'm not sure.)

Updated: Added triple quote & escaped hash detection, fixed multi-line string pruning

from sparqlwrapper.

hmm, while this seems to solve the comment problem, in #32 @gromgull already mentioned that it could be beneficial to use the rdflib sparql parser to do this properly... i'd actually vote for that as it reduces code-duplication for partial parsing with weird side effects like this...

from sparqlwrapper.

The only downside might be (although maybe I'm wrong?) that it's considerably less efficient to ask rdflib to parse it first (assuming regex uses C extension). Wouldn't it be better to rely on the user to indicate whether they're trying to perform a query or update request? After all, they must know what they're doing in order to do something with (or the lack of) response data from the request anyway. I do realise this would break backwards compatibility so presumably is out of the question.
(Whilst e.g. SQL libraries have a single query() function, they still assume the user to know what they're doing with what comes back.)

from sparqlwrapper.

One last thought: How about if query() allows one to specify whether it's a query or an update request but make the parameter optional (and, if not specified, check query for type as before).

from sparqlwrapper.