SPARQLWrapper 1.6.3 doesn't work in py3 about sparqlwrapper HOT 12 CLOSED

@wikier Hopefully you can do a patch release fast so others aren't bitten by this. :)

from sparqlwrapper.

@alf why __init__.py is required to be ascii?

from sparqlwrapper.

__init__.py is not required to be ascii, but in line 38 of your setup.py you do for line in open('SPARQLWrapper/__init__.py'):. You need to specify the encoding for that to work.

See https://docs.python.org/3/howto/unicode.html#reading-and-writing-unicode-data

from sparqlwrapper.

@alf I think I have fixed the release. Can you please check it?

from sparqlwrapper.

No, still not fixed. The module docstring contains the name Sergio Fernández but is not defined as a unicode string.

from sparqlwrapper.

@wikier could you maybe make this 1.6.4 instead of moving the tag? (cause different same version releases get us into hell)

from sparqlwrapper.

@joernhees is right, we keep 1.6.3 as it was, and we try to quickly address this issue for 1.6.4.

from sparqlwrapper.

@alf can you please check if the current HEAD of master would satisfy such environment requirement? It never failed to me.

from sparqlwrapper.

No, you haven't fixed the issue. How about going with my initial suggestion? Changing the names of contributors so they don't fall outside of the ascii range is not a good way to solve this.

The problem isn't in SPARQLWrapper/__init__.py, it's in setup.py. The following should fix it.

diff --git a/setup.py b/setup.py
index 3026b67..0d5f9ac 100755
--- a/setup.py
+++ b/setup.py
@@ -35,7 +35,7 @@ if py3:
     _version_re = re.compile(r'__version__\s*=\s*"(.*)"')
     _authors_re = re.compile(r'__authors__\s*=\s*"(.*)"')
     _url_re = re.compile(r'__url__\s*=\s*"(.*)"')
-    for line in open('SPARQLWrapper/__init__.py'):
+    for line in open('SPARQLWrapper/__init__.py', encoding='utf-8'):
         version_match = _version_re.match(line)
         if version_match:
             version = version_match.group(1)

from sparqlwrapper.

Oh sorry, I got it wrong. I did not remember the workaround we have for avoiding metadata duplication.

I've applied your patch. So, if that looks fine, we can quickly publish a 1.6.4 patch release.

from sparqlwrapper.

Voila, works like a charm. Thanks for working with me on this :)

alf@core-01:~/$ pip3 -q install "https://github.com/RDFLib/sparqlwrapper/tarball/master#egg=SPARQLWrapper-1.6.4-pre"
alf@core-01:~/$ echo $?
0

from sparqlwrapper.

Thanks for the quick notice ;-)

from sparqlwrapper.