enhance warning for missing rdflib-jsonld about sparqlwrapper HOT 8 CLOSED

I'm not a big fan of warnings. I don't see much value in them. I think it's better to just work until we can't at which point exception should be raised. Warnings are used to mask inconsistencies in design.

I think it is ok to tweak this for 1.7 (no need to change behaviour in 1.6). I would prefer to get rid of warnings in 2.x

from sparqlwrapper.

I agree - this warning bugs me too.
Should be thrown as an exception when I try to retrieve JSON-LD but can not.

On Thu, Jul 31, 2014 at 1:23 PM, Alexey Zakhlestin <[email protected]

wrote:

I'm not a big fan of warnings. I don't see much value in them. I think
it's better to just work until we can't at which point exception should be
raised. Warnings are used to mask inconsistencies in design.

I think it is ok to tweak this for 1.7 (no need to change behaviour in
1.6). I would prefer to get rid of warnings in 2.x

—
Reply to this email directly or view it on GitHub
#38 (comment).

from sparqlwrapper.

The reason why that's a warning it's because there is not reason in the protocol whether a SPARQL endpoint should provide JSON-LD support.

The warning is not shown at request time, just at the wrapper initialization to dynamically setup the allowed formats.

Therefore it can't be an exception. But I'm happy to list to idea how to properly warn the user about such limitation of the environment where the code runs. From my point of view these are the options:

• keep the warning, so the user notice it and can install such optional dependency
• move the warning to setReturnFormat() (now silently ignores invalid formats)
• remove the warning at all

I'm not happy with the last one, but the other two options sound good for me.

from sparqlwrapper.

@wikier I think the consensus is, that it's better to remove the warning and throw exception just when this functionality is requested (but can't be provided).

additionally, there might be a method for explicit check:

def supports(functionality: str) -> bool:
    if str == JSONLD:
        return JSONLD in _allowedFormats
    …

(I used py3k type-hints syntax to clarify intentions, obviously, we can't have it in actual code)

from sparqlwrapper.

OK, according the feedback, the changes has been introduced. Please @joernhees, @indeyets and @mgaldzic, check if they implement the expected behavior to close this issue.

from sparqlwrapper.

@wikier 👍 much better, i left an idea for improvement in the code which raises the exception

from sparqlwrapper.

I think we can consider this resolved, isn't it?

from sparqlwrapper.

👍 thanks a lot :)

from sparqlwrapper.