Git Product home page Git Product logo

Comments (11)

Mervap avatar Mervap commented on June 4, 2024 1

Yes, it seems the original problem is solved. Thanks

from rcppeigen.

Mervap avatar Mervap commented on June 4, 2024

Similarly with the argument force

from rcppeigen.

eddelbuettel avatar eddelbuettel commented on June 4, 2024

Confirmed the example_code=FALSE case, and corrected in a branch in just pushed. Tested all four cases of example_cide equal to TRUE or FALSE with or without pkgKitten installed.

I do not know what you mean by your second remark.

from rcppeigen.

Mervap avatar Mervap commented on June 4, 2024

I do not know what you mean by your second remark.

I wanted to say that calling the following code

RcppEigen::RcppEigen.package.skeleton(force = TRUE)

results in a similar error

Calling kitten to create basic package.
Error in (function (name = "anRpackage", path = ".", author, maintainer, : unused argument (force = TRUE)

Error in value[3L] : error while calling kitten

from rcppeigen.

eddelbuettel avatar eddelbuettel commented on June 4, 2024

force is indeed an unused argument. It is there, but does nothing.

Which is what R tells you: "you gave me an argument 'force', there is nothing I can do with it". Which is correct. I should probably remove it -- or you should just not use it :)

from rcppeigen.

Mervap avatar Mervap commented on June 4, 2024

force is indeed an unused argument. It is there, but does nothing.

I think this argument is necessary
Let's look at the documentation RcppEigen.package.skeleton

Arguments:
...
force: See package.skeleton

The expected behavior is identical to package.skeleton
Let's look at the documentation package.skeleton

Arguments:
...
force: If β€˜FALSE’ will not overwrite an existing directory.

At a minimum, the inability to create a project inside an existing folder is depressing

RcppEigen::RcppEigen.package.skeleton('testProj')

Calling kitten to create basic package.
Error: Directory 'testProj' already exists. Aborting.

Error in value[3L] : error while calling kitten

from rcppeigen.

Mervap avatar Mervap commented on June 4, 2024

Among other things, in Rcpp::Rcpp.package.skeleton argument force is working fine and as expected

from rcppeigen.

eddelbuettel avatar eddelbuettel commented on June 4, 2024

Two things:

  1. Yes, force was just there because the R base package.skeleton() can use it. As you identified, it let to a second ugly error if was present AND pkgKitten was used. I just fixed that, similar to above.

  2. The Error: Directory 'testProj' already exists. Aborting. is just R telling you that you directory already has a directory named testProj. It has always been like that. I was just tesing with testPkgA, testPkgB, testPkgC, ... and so on.

from rcppeigen.

Mervap avatar Mervap commented on June 4, 2024

I don't think we understand each other
I am well aware of what these warnings mean, but I think they need to be corrected
It seems logical to me to be able to create a package inside a pre-created directory
And also it seems to me a terrible bug that RcppEigen::RcppEigen.package.skeleton(force = TRUE) will correctly generate the package in an existing directory if there is no pkgKitten and will crash with the error above if it is install

from rcppeigen.

eddelbuettel avatar eddelbuettel commented on June 4, 2024

Please look at the branch I commited minutes ago (as I said I would; but only now pushed, sorry). It deals with the force && pkgKitten issue.

If there is anything else, please open a new issue.

I do not plan to address isues caused by R itself as both and without pkgKitten we do use R's own package.skeleton. And it will not proceed creating a new package with a given name if a directory with that name already exists.

Otherwise, please help me disentangling the different discussion threads. Thank you.

from rcppeigen.

eddelbuettel avatar eddelbuettel commented on June 4, 2024

Please try now. The original issues should now be better. Thanks for bringing them up.

from rcppeigen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.