Git Product home page Git Product logo

Comments (8)

rcbyr avatar rcbyr commented on August 26, 2024 1

@sergiodebei
Thanks for the hint. I just fixed it and make a new release. (v5.0.4 - changes in CSS and JS)

from keen-slider.

sergiodebei avatar sergiodebei commented on August 26, 2024

Thank you so much for the quick response. Im gonna use it for some other new projects :)

from keen-slider.

Hujjat avatar Hujjat commented on August 26, 2024

Hey @rcbyr

Just want to let you know, The links are still firing when you drag the slider. I tried data-keen-slider-pe on the link. Not working.

Thanks

from keen-slider.

patrickdmccarthy avatar patrickdmccarthy commented on August 26, 2024

@rcbyr data-keen-slider-pe doesn't seem to work in "keen-slider": "6.4.1" – is there another way around this in the new version?

from keen-slider.

rcbyr avatar rcbyr commented on August 26, 2024

Hey @patrickdmccarthy,

look at the documentary. https://keen-slider.io/docs#attributes
The attribute name has changed to data-keen-slider-clickable.

Generally, you do not need this attribute for links or buttons. They will work without this attribute. Therefore I will probably rename this attribute soon.

from keen-slider.

sagrael avatar sagrael commented on August 26, 2024

v6.4.1 data-keen-slider-clickable not working on angular + [routerLink]

fixed it like this

::ng-deep {
  .keen-slider[data-keen-slider-moves] .linkClass {
    pointer-events: none;
  }
}

from keen-slider.

rcbyr avatar rcbyr commented on August 26, 2024

Hey @sagrael

can you create a codesandbox? It works for me.

from keen-slider.

danielrob avatar danielrob commented on August 26, 2024

data-keen-slider-clickable just seems to disable the click events altogether - no drag is now possible. Is it possible to have both drag and no mouseup link click after dragging?

Update: Looks like my timing was just very unlucky - a bug in 6.8.0 fixed in 6.8.1 https://github.com/rcbyr/keen-slider/releases/tag/v6.8.1. It works now without the attribute.

from keen-slider.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.