css-purge always minifies, no matter which trim option is enabled about css-purge HOT 6 CLOSED

Hi there @COLABORATI, can you describe your setup to me? Are you using it via a plugin or as a library, or local or global command line?

from css-purge.

I think I can reproduce this issue.

In my setup I'm using node-sass to compile scss files to css. Since I'm optimizing for http2 I'm creating bundles for every module on the page.
However, as a fallback I had to create a bundle that includes all code and just imported every single module bundle.
In my case bootstrap gets included several times, but if I just use the node-sass outputStyle compressed, it blews up my bundle like hell. So I found css-purge to be a very good solution.

Here is my setup:

sass.render({
    // ... sass options
}, (error, result) => {
    if (error) { console.log(error) } else {
        const css = result.css.toString(); // need this since result.css is a Buffer
        
        cssPurge.purgeCSS(
            css,
            {
                trim: false,
                shorten: false,
                format: false,
            },
            (purgeError, purgeResult) => {
                if (purgeError) { console.log(purgeError) } else {
                    // ... write file
                }
            }
        });
    }
});

The css-purge options don't change result, doesn't matter which ones I choose. (e.g. last rule semicolons always get removed)
It even goes to the point where something gets formated in a way that leads to missing '}'s as the css parser states.
Error Message from css parser:

CSS Parser Error: probably have something funny in your CSS, change it then please try again.
Reason: @supports missing '}'
Line: 3
Column: 49
Filename: demo/test1.css

Which is odd, since it's a file in your package and I don't use it anywhere.

I'm using css-purge 3.0.10.
Hope you can help

from css-purge.

Hmm, I'll have to test and have a look at it, kinda busy right now though, lemme see if I can get to it this weekend.

from css-purge.

Hey guys, finally found the issue, it was the default vars, my bad, sorted.

You should be able to just update gulp-css-purge else uninstall and reinstall.

from css-purge.

I'm seeing this with css-purge 3.0.13 — just the plain node module, from the command line. I'm running CSS-PURGE against the output of my SCSS compilation, with the intent of looking over the diffs to identify duplications etc. and then going back to the SCSS source to fix them. Eliminating comments and whitespace and newlines and extra semicolons makes this difficult.

I tried explicitly specifying the default (?) config file, which appears to disable trim_comments, trim_whitespace, trim_breaklines, and trim_last_semicolon, with -f`, but the output is a minified single line without comments or trailing semicolons.

Per the trim docs (“Only when its off can you turn on or off the other trim options”) I then tried setting "trim": "false", but the output was identical.

Am I misunderstanding the config? Am I doing something else wrong? Is the available node module out of date?

from css-purge.

@dmolesUC3 thanks for the heads up, I believe I sorted out the issue.

from css-purge.