Git Product home page Git Product logo

Comments (5)

jfkisafk avatar jfkisafk commented on July 24, 2024 1

The optimal solution would be to replace pagination like these:

extensions/extensions/slack/src/shared/client/SlackClient.ts

Lines 84 to 94 in 5c077f5

let cursor: string | undefined;
do {
const response = await slackWebClient.users.list({
limit: 1000,
cursor,
});
slackMembers.push(...(response.members ?? []));
cursor = response.response_metadata?.next_cursor;
} while (cursor);
return slackMembers;

with:

  1. (recommended) just retrieve the first page and support typeahead search. We will need to explore if all the APIs support a search pattern to restrict the results. For example, can't find it for https://api.slack.com/methods/users.list
  2. raycast native pagination and a typeahead search. But unless we figure out an API that supports typeahead search pattern, I think users of large workspaces will need to keep scrolling down to retrieve all items and search.

from extensions.

raycastbot avatar raycastbot commented on July 24, 2024

Thank you for opening this issue!

🔔 @momme-rtf @Elliot67 @jfkisafk @thomaslombart you might want to have a look.

💡 Author and Contributors commands

The author and contributors of mommertf/slack can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopens the issue.
  • @raycastbot assign me Assigns yourself to the issue.
  • @raycastbot good first issue Adds the "Good first issue" label to the issue.
  • @raycastbot keep this issue open Make sure the issue won't go stale and will be kept open by the bot.

from extensions.

thomaslombart avatar thomaslombart commented on July 24, 2024

Could you share a recording? It'll make it easier to see what's happening.

from extensions.

LewisLebentz avatar LewisLebentz commented on July 24, 2024

@thomaslombart don't have my Mac with me at the moment, probably won't be able to send anything until tomorrow.

But literally nothing happens. I did a quick GitHub search and it seems like this memory issue is quite widespread across multiple extensions wherever it is processing a large amount of data.

from extensions.

Elliot67 avatar Elliot67 commented on July 24, 2024

Very likely an issue with large workspace : #4284

When pulling data from the Slack API, the extension doesn't stop pulling until it gets every users, channels and messages.

from extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.