Comments (9)
That's a great finding @InitPatch ! I found an issue with my logic. It was using /opt/homebrew/bin/ffmpeg
even if you provided another location. I'll push the fix in the same PR. Also I will add /usr/local/Cellar/ffmpeg
as another possible PATH so you don't even have to change it when the fix is released.
from extensions.
@InitPatch it seems they released a new major version this month (ffmpeg 7
). I was using v6 to develop this extension. Let me try with v7 and try to make it compatible
from extensions.
Hey @pablopunk,
I confirm it works now! 🙌🏼 Thank you!
One thing though. If I select more than one file in Finder, it will still display 1 task in the queue only:
![image](https://private-user-images.githubusercontent.com/15719066/327586463-6f978614-4ad3-4b75-9298-2d8d09587ce1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ5MjM4MzMsIm5iZiI6MTcxNDkyMzUzMywicGF0aCI6Ii8xNTcxOTA2Ni8zMjc1ODY0NjMtNmY5Nzg2MTQtNGFkMy00Yjc1LTkyOTgtMmQ4ZDA5NTg3Y2UxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTA1VDE1Mzg1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmNWQzZTZlYjVjYzVlYTFiZTc3Zjg3NjZkZWUzZjk1ZjRhODNjZmIyMjFkOTUzNTVhZTExY2I1N2ZlMzczYTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.CK1kQc_-akPTWKkrS0B9174xhq0W5ntj25CQ5JjgHvg)
This means I'll have to add the other file(s) by clicking on the Add file button.
Since the extension works based on a selected file in Finder, it would make sense that whatever the amount of selected video files are selected in the Finder, would be added to the queue.
As much as keeping the "Add File" button, in case you know where your files are and not in the current folder in Finder at that moment.
Another thing I'd add, is a progress bar while it compresses the video(s).
The first time I used it, I waited, like 22 sec for a 100 MB video file for instance, but I wasn't sure what would happen if I'd close the Raycast window; would it stop the job or not? Because that's for a 100 MB file but how long will it be on a bigger file or several files, right?
It turns out it does the job, even in the background, but I feel like that'd be nice to have a progress bar system, even within a floating window for instance (in the case you close the Raycast window or do something else with Raycast. See what I mean?)
Also, small thing, but since you're displaying the compressed files in quite big size, it'd be cool to have a thumbnail on the file(s), when the compression is done:
![image](https://private-user-images.githubusercontent.com/15719066/327590341-ec67885d-3f82-4790-81d4-be2aca3a7866.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ5MjM4MzMsIm5iZiI6MTcxNDkyMzUzMywicGF0aCI6Ii8xNTcxOTA2Ni8zMjc1OTAzNDEtZWM2Nzg4NWQtM2Y4Mi00NzkwLTgxZDQtYmUyYWNhM2E3ODY2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTA1VDE1Mzg1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTMzMGMxYzhmNjI2M2I1ZjU5MzA4NGZmYmYxYmQwZjBiYjBmYTg2ZjRjOWVkOThkNjc4Nzg5YTA4Y2M1NTc5NDcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.i_Al_Bv1ao3b1iNlgC6GfFTgMKWXedaW4Cxbg2engtQ)
VS ↴
![image](https://private-user-images.githubusercontent.com/15719066/327588328-6fab76fa-1180-4492-a4b7-438921c7e9a2.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ5MjM4MzMsIm5iZiI6MTcxNDkyMzUzMywicGF0aCI6Ii8xNTcxOTA2Ni8zMjc1ODgzMjgtNmZhYjc2ZmEtMTE4MC00NDkyLWE0YjctNDM4OTIxYzdlOWEyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTA1VDE1Mzg1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJjNWI3YjMyNjZiMzc2MGJkYWQyYjBiZTQ0OThiOGU4MTRkNDNjZmZjNzhhOGE3Yjg3ZjRjZTBiNTkyNjk4MWMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.K6xIZdA-cNimGQ65nZ2J-vFgdUoE-RclJovkGYh4Eho)
from extensions.
I think [this](https://developers.raycast.com/utilities/icons/getprogressicon#signature) could work
No idea, I'm not a coder, just a simple user 🙃
from extensions.
Thank you for opening this issue!
🔔 @pablopunk you might want to have a look.
💡 Author and Contributors commands
The author and contributors of pablopunk/yafw
can trigger bot actions by commenting:
@raycastbot close this issue
Closes the issue.@raycastbot rename this issue to "Awesome new title"
Renames the issue.@raycastbot reopen this issue
Reopens the issue.@raycastbot assign me
Assigns yourself to the issue.@raycastbot good first issue
Adds the "Good first issue" label to the issue.
from extensions.
Update: v7 works fine for me. I made another PR to easily see logs in production so I can debug this one
from extensions.
Sweet, thanks!
I'll wait for your PR to be approved. Meanwhile, I went to the extension preferences and noticed the current path is /opt/homebrew/bin/ffmpeg
. However, when I checked this path in Finder I didn't see FFMPEG in there:
![image](https://private-user-images.githubusercontent.com/15719066/326915805-f73b57d4-dcc2-440e-a143-57cfffc9dbc0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ5MjM4MzMsIm5iZiI6MTcxNDkyMzUzMywicGF0aCI6Ii8xNTcxOTA2Ni8zMjY5MTU4MDUtZjczYjU3ZDQtZGNjMi00NDBlLWExNDMtNTdjZmZmYzlkYmMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTA1VDE1Mzg1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWJkMjhkZjE3MWRiNjJiZTJkYTRjMjM0NmViYzBiYmFhNDFhMzI5MWRmNjMzZjg5NjFlYTlmYzgxNDg3MWIyY2UmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.eSNJu6lN1S1yU-EuKpovjkyZCKRNAqtyGWij9F2uIwo)
Instead, I found it there:
![image](https://private-user-images.githubusercontent.com/15719066/326916332-c13e2138-d12c-4620-8349-c8175cad4802.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTQ5MjM4MzMsIm5iZiI6MTcxNDkyMzUzMywicGF0aCI6Ii8xNTcxOTA2Ni8zMjY5MTYzMzItYzEzZTIxMzgtZDEyYy00NjIwLTgzNDktYzgxNzVjYWQ0ODAyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MDUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTA1VDE1Mzg1M1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWRmNjQ3Zjg4MjUyZGY3MGFlYzE2YjcyOWU1MWIzZjkwYzg3NWM5ZWI2OTlmMTgxMWFmMDdkZTZiMzg1NjZhYTQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.PiigtLhbECqOx2yti8rhPSR0oJg1lN3wR9s57e2UsT8)
Should I change it to /usr/local/Cellar/ffmpeg/
or /usr/local/Cellar/ffmpeg/7.0_1
in the extension preferences? ... or?
from extensions.
@InitPatch can you try with the new version of the extension?
from extensions.
Since the extension works based on a selected file in Finder, it would make sense that whatever the amount of selected video files are selected in the Finder, would be added to the queue.
that's the intention, so it's indeed a bug
Another thing I'd add, is a progress bar while it compresses the video(s).
that'd be nice. It's tricky, cause it would need to parse the stdout of ffmpeg and somehow display the progress (I think this could work)
Also, small thing, but since you're displaying the compressed files in quite big size, it'd be cool to have a thumbnail on the file(s), when the compression is done:
that was my first idea and I tried so hard to make it work but I couldn't find a way. Maybe @pernielsentikaer knows a way?
from extensions.
Related Issues (20)
- [Bilibili] Functional Recommendations HOT 4
- [Apple Notes] applenotes:// does not work on Monterey HOT 1
- [gitlab] add option to filter out MRs you already approved from "My reviews" HOT 2
- [Send to Workflowy Inbox] ... HOT 3
- [Session - Pomodoro Focus Timer] Start New Session should include category and intention fields HOT 1
- [Arc] Unable to fetch latest data HOT 4
- Fails, needs an *.EXE [Capture Fullpage of Website] ... HOT 1
- [Pomodoro] Show remaining timer duration in Raycast window HOT 1
- [SSH Tunnel Manager] It's not possible to add SSH tunnel with a dot in the name HOT 2
- [Jira] Error management can be improved HOT 1
- [Dashlane Vault]... HOT 1
- [Timers] ... HOT 1
- [Zed] search recent projects not working HOT 2
- [1Password] ... HOT 5
- [GitHub] Ability to see all Comments / full Conversation of a pull request HOT 1
- NPM Run Publish - Aborting commit due to empty commit message.
- [1Password] Can't get "Open in 1Password" secondary action to work HOT 3
- [Jira] Failure to use the application at all HOT 5
- [Base64] Losing the line breaks HOT 1
- [Terminal Finder] do not open directory HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from extensions.