Git Product home page Git Product logo

Comments (9)

pablopunk avatar pablopunk commented on August 18, 2024 2

That's a great finding @InitPatch ! I found an issue with my logic. It was using /opt/homebrew/bin/ffmpeg even if you provided another location. I'll push the fix in the same PR. Also I will add /usr/local/Cellar/ffmpeg as another possible PATH so you don't even have to change it when the fix is released.

from extensions.

pablopunk avatar pablopunk commented on August 18, 2024 1

@InitPatch it seems they released a new major version this month (ffmpeg 7). I was using v6 to develop this extension. Let me try with v7 and try to make it compatible

from extensions.

InitPatch avatar InitPatch commented on August 18, 2024 1

Hey @pablopunk,
I confirm it works now! 🙌🏼 Thank you!

One thing though. If I select more than one file in Finder, it will still display 1 task in the queue only:

image

This means I'll have to add the other file(s) by clicking on the Add file button.
Since the extension works based on a selected file in Finder, it would make sense that whatever the amount of selected video files are selected in the Finder, would be added to the queue.
As much as keeping the "Add File" button, in case you know where your files are and not in the current folder in Finder at that moment.

Another thing I'd add, is a progress bar while it compresses the video(s).
The first time I used it, I waited, like 22 sec for a 100 MB video file for instance, but I wasn't sure what would happen if I'd close the Raycast window; would it stop the job or not? Because that's for a 100 MB file but how long will it be on a bigger file or several files, right?
It turns out it does the job, even in the background, but I feel like that'd be nice to have a progress bar system, even within a floating window for instance (in the case you close the Raycast window or do something else with Raycast. See what I mean?)

Also, small thing, but since you're displaying the compressed files in quite big size, it'd be cool to have a thumbnail on the file(s), when the compression is done:

image

VS ↴

image

from extensions.

InitPatch avatar InitPatch commented on August 18, 2024 1

I think [this](https://developers.raycast.com/utilities/icons/getprogressicon#signature) could work
No idea, I'm not a coder, just a simple user 🙃

from extensions.

raycastbot avatar raycastbot commented on August 18, 2024

Thank you for opening this issue!

🔔 @pablopunk you might want to have a look.

💡 Author and Contributors commands

The author and contributors of pablopunk/yafw can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopens the issue.
  • @raycastbot assign me Assigns yourself to the issue.
  • @raycastbot good first issue Adds the "Good first issue" label to the issue.

from extensions.

pablopunk avatar pablopunk commented on August 18, 2024

Update: v7 works fine for me. I made another PR to easily see logs in production so I can debug this one

from extensions.

InitPatch avatar InitPatch commented on August 18, 2024

Sweet, thanks!
I'll wait for your PR to be approved. Meanwhile, I went to the extension preferences and noticed the current path is /opt/homebrew/bin/ffmpeg. However, when I checked this path in Finder I didn't see FFMPEG in there:

image

Instead, I found it there:

image

Should I change it to /usr/local/Cellar/ffmpeg/ or /usr/local/Cellar/ffmpeg/7.0_1 in the extension preferences? ... or?

from extensions.

pablopunk avatar pablopunk commented on August 18, 2024

@InitPatch can you try with the new version of the extension?

from extensions.

pablopunk avatar pablopunk commented on August 18, 2024

Since the extension works based on a selected file in Finder, it would make sense that whatever the amount of selected video files are selected in the Finder, would be added to the queue.

that's the intention, so it's indeed a bug

Another thing I'd add, is a progress bar while it compresses the video(s).

that'd be nice. It's tricky, cause it would need to parse the stdout of ffmpeg and somehow display the progress (I think this could work)

Also, small thing, but since you're displaying the compressed files in quite big size, it'd be cool to have a thumbnail on the file(s), when the compression is done:

that was my first idea and I tried so hard to make it work but I couldn't find a way. Maybe @pernielsentikaer knows a way?

from extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.