Git Product home page Git Product logo

Comments (9)

xilopaint avatar xilopaint commented on June 27, 2024 2

I think this would create immense confusion. The colors of these icons on GitHub UI reflect the statuses of issues and PRs: issues can be open, closed, or not planned (green, purple, and gray), and PRs can be open, closed, or merged (green, red, and purple).

Anything different from this pattern would be counterintuitive and a big mistake.

Also, the Unread and Read sections already clearly communicate the status of the notifications.

The key question is whether we should color the icons according to the correct GitHub pattern. In my view, yes, we should. This way, if I have a purple PR icon in the Unread section, I know that I'm being notified about a merged PR. This adds real information to the UI.

from extensions.

raycastbot avatar raycastbot commented on June 27, 2024

Thank you for opening this issue!

🔔 @thomaslombart @unnamedd @tonka3000 @khasbilegt @pernielsentikaer @loxygenK @oilbeater @LunaticMuch @aeorge @daquinoaldo @peppy @aeither @marcotf @qeude @nesl247 you might want to have a look.

💡 Author and Contributors commands

The author and contributors of raycast/github can trigger bot actions by commenting:

  • @raycastbot close this issue Closes the issue.
  • @raycastbot rename this issue to "Awesome new title" Renames the issue.
  • @raycastbot reopen this issue Reopen the issue.

from extensions.

thomaslombart avatar thomaslombart commented on June 27, 2024

Good idea! Do you want to actually look at it?

from extensions.

teziovsky avatar teziovsky commented on June 27, 2024

I'm confident in my ability to enhance it, but I'd like your input on which example you find more preferable 🤔 Alternatively if you have any other suggestions for resolving this, I'm open to hearing them 🤔

from extensions.

thomaslombart avatar thomaslombart commented on June 27, 2024

I think I'll go for shades of gray here as orange and green may be too distracting.

from extensions.

teziovsky avatar teziovsky commented on June 27, 2024

I think it's not possible to implement. I mean shades of gray in List.Item title. The title could only get value and tooltip props 🤔

from extensions.

teziovsky avatar teziovsky commented on June 27, 2024

What do you think about those examples:
github 2024-03-01 at 13 30 57
github 2024-03-01 at 13 30 44
github 2024-03-01 at 13 30 33

from extensions.

teziovsky avatar teziovsky commented on June 27, 2024

I think this would create immense confusion. The colors of these icons on GitHub UI reflect the statuses of issues and PRs: issues can be open, closed, or not planned (green, purple, and gray), and PRs can be open, closed, or merged (green, red, and purple).

Anything different from this pattern would be counterintuitive and a big mistake.

Also, the Unread and Read sections already clearly communicate the status of the notifications.

The key question is whether we should color the icons according to the correct GitHub pattern. In my view, yes, we should. This way, if I have a purple PR icon in the Unread section, I know that I'm being notified about a merged PR. This adds real information to the UI.

Agree with that.

from extensions.

thomaslombart avatar thomaslombart commented on June 27, 2024

Yeah, I meant using Color.SecondaryText for the read section as the gray color is less visible like below:

github 2024-03-04 at 12 34 14

But applying the actual colors as done on GitHub's UI is a great idea as well. I'm fine with both. 🙂

from extensions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.