Comments (9)
I think this would create immense confusion. The colors of these icons on GitHub UI reflect the statuses of issues and PRs: issues can be open, closed, or not planned (green, purple, and gray), and PRs can be open, closed, or merged (green, red, and purple).
Anything different from this pattern would be counterintuitive and a big mistake.
Also, the Unread and Read sections already clearly communicate the status of the notifications.
The key question is whether we should color the icons according to the correct GitHub pattern. In my view, yes, we should. This way, if I have a purple PR icon in the Unread section, I know that I'm being notified about a merged PR. This adds real information to the UI.
from extensions.
Thank you for opening this issue!
🔔 @thomaslombart @unnamedd @tonka3000 @khasbilegt @pernielsentikaer @loxygenK @oilbeater @LunaticMuch @aeorge @daquinoaldo @peppy @aeither @marcotf @qeude @nesl247 you might want to have a look.
💡 Author and Contributors commands
The author and contributors of raycast/github
can trigger bot actions by commenting:
@raycastbot close this issue
Closes the issue.@raycastbot rename this issue to "Awesome new title"
Renames the issue.@raycastbot reopen this issue
Reopen the issue.
from extensions.
Good idea! Do you want to actually look at it?
from extensions.
I'm confident in my ability to enhance it, but I'd like your input on which example you find more preferable 🤔 Alternatively if you have any other suggestions for resolving this, I'm open to hearing them 🤔
from extensions.
I think I'll go for shades of gray here as orange
and green
may be too distracting.
from extensions.
I think it's not possible to implement. I mean shades of gray in List.Item
title
. The title
could only get value
and tooltip
props 🤔
from extensions.
What do you think about those examples:
from extensions.
I think this would create immense confusion. The colors of these icons on GitHub UI reflect the statuses of issues and PRs: issues can be open, closed, or not planned (green, purple, and gray), and PRs can be open, closed, or merged (green, red, and purple).
Anything different from this pattern would be counterintuitive and a big mistake.
Also, the Unread and Read sections already clearly communicate the status of the notifications.
The key question is whether we should color the icons according to the correct GitHub pattern. In my view, yes, we should. This way, if I have a purple PR icon in the Unread section, I know that I'm being notified about a merged PR. This adds real information to the UI.
Agree with that.
from extensions.
Yeah, I meant using Color.SecondaryText
for the read section as the gray color is less visible like below:
But applying the actual colors as done on GitHub's UI is a great idea as well. I'm fine with both. 🙂
from extensions.
Related Issues (20)
- [Next.js Documentation] ... out of date HOT 1
- [copy-path] Add Firefox as supported browser HOT 1
- [iMessage 2FA] Incorrect 2FA code from USAA HOT 5
- [Parallels Virtual Machines] Shortcut to each machine HOT 1
- [GIF Search] ... Doesn't show any gif's sometimes when searching for stuff HOT 1
- [Roam Research] Add quick capture for tasks HOT 1
- [Obsidian] Hide frontmatter properties and rendered code blocks HOT 1
- [Bing Wallpaper] ... HOT 1
- [Raycast Arcade] ... HOT 1
- [Miro] can you make it that I can find boards in my team, and not just my own owned ones please HOT 1
- [Miro] Could we have a way of creating a new board without typing name and selecting the type each time? HOT 1
- [GitLab] Show only open merged requests in "My merge request" HOT 1
- [Amazon AWS] s3: list bucket objects by "folder" HOT 2
- [Arc] Move Media to Picture-In-Picture HOT 1
- [Open Graph] Add support to relative media URLs HOT 7
- `getSelectedText()` doesn't select text from Raycast AI window
- [Single Focus] Error, nothing happening when executing command HOT 1
- [Browser Bookmarks] Ability to enable or disable bookmark folders HOT 2
- [Linear] Impossible to create an issue in a team that has a Custom Emoji (imported from slack) HOT 4
- [Color Picker] Support P3 colors HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from extensions.