Pass custom dns resolver about pawl HOT 6 CLOSED

Possibility to use \React\SocketClient\TcpConnector instead of \React\SocketClient\DnsConnector would be great to.

from pawl.

The connect function is meant to simplify 90% of use cases by having a minimal API. The Connector class allows more customization, including a custom DNS Resolver, which is what you should use if that's required.

I don't quite follow your second comment about the Connectors?

from pawl.

@cboden after half a year, I'm not sure, what I did mean.
But I think, it's about src/Connector.php:

$this->_connector       = new SocketConnector($loop, $resolver);

SocketConnector is deprecated and \React\SocketClient\DnsConnector's wrapper.
So, I think it would better have possibility to provide connector. If it isn't passed, use \React\SocketClient\DnsConnector.

So, ok, I can create my own function create, but I can't provide custom connector to \Ratchet\Client\Connector::__construct().
Instead of parameter Resolver $resolver = null we can use connector parameter.

from pawl.

The connect function is meant to simplify 90% of use cases by having a minimal API. The Connector class allows more customization, including a custom DNS Resolver, which is what you should use if that's required.

Also it would great to add doc to function connect about it.

from pawl.

+1 for adding a connector argument to the constructor instead of the resolver.

from pawl.

With the release of v0.3 you can now customize DNS information on the Connector class via React's Connector class. See the example at the bottom of the README for an example.

from pawl.