Does not Build with Clang on rpi about libcamera HOT 8 CLOSED

I found a place to sprinkle some #pragma bits, but this may be an upstream bug in some senses.

from libcamera.

LMK if you want a PR with the std::move in the various marked places above. Also happy to setup some GH CI actions to help lock this in.

from libcamera.

I can reproduce the ; issue with clang-13 on x86, so that definitely deserves a fix. I see two options, either adding a local patch to pybind11 in the wrap, or disabling the -Wextra-semi warning for the Python bindings. I have a small preference for the former.

The std::move() issue seems valid too. The compiler is required to perform return value optimization starting in C++17, which removes the need for std::move() in a return statement in most cases. There are exceptions though, in particular when the return type of the function and the type of the local variable don't match. This seems to be the case here. However, while I could reproduce the issue with clang-9, it disappeared with clang-13. I thus wonder if it's a false positive with earlier clang versions, or a false negative with newer versions. In any case, we want to support the most commonly used clang versions, so a fix probably makes sense.

from libcamera.

I opened #16 for the std::move issue. The most up to date pybind has a pretty different look around the lines mentioned, so it may be worth seeing if a version bump kills this issue.

from libcamera.

Removing the semicolon on ../subprojects/pybind11-2.6.1/include/pybind11/detail/common.h and using the diff from #16 gets this working.

from libcamera.

I believe this should now be resolved. Feel free to re-open if there are still issues.

from libcamera.

Awesome. Thank you.

I have some interest in adding support for reading the temperature sensor on the IMX477. Do you participate in the libcamera channel?

from libcamera.

I am there occasionally, but probably better to open a github issue/pr to discuss this.

from libcamera.