Add support for compound controls about libcamera HOT 6 CLOSED

@naushir
Hello, I'm working to add support for v4l2 array controls as per your
8893388 ("DNI: Add U8 compound control for RPi IPA.")

I'm currently failing to find a use case for that in your code base. Should I expect the unicam driver to register a U8 control in future, or am I missing the current use case?

from libcamera.

Hi @jmondi, the compound controls are used by the ISP driver (bcm2835-v4l2-isp.c). If you look at the IPA code (src/libcamera/pipeline/raspberrypi/raspberrypi.cpp), most of the apply*() functions set compound controls to the ISP driver.

from libcamera.

Here you go:

ControlValue c(reinterpret_cast<uint8_t *>(&ccm), sizeof(ccm));
ctrls.set(V4L2_CID_USER_BCM2835_ISP_CC_MATRIX, c);

Thanks, that will help validating my implementation.

from libcamera.

Support for compound controls has been merged to master, thanks to @jmondi and @pinchartl
Closing this task.

from libcamera.

Ooops, I was too trigger happy. Sounds like there is still a little bit of development left to do to tie this into the V4L2 layers.

from libcamera.

Done now :-)

from libcamera.