Git Product home page Git Product logo

Comments (4)

raquo avatar raquo commented on May 20, 2024 2

name -> nameAttr

Basically same logic as id. If one is renamed the other should probably be too.

from scala-dom-types.

raquo avatar raquo commented on May 20, 2024 2

param -> paramTag

Very niche tag hogging a good name. Specifically, conflicts with URL DSL's query param name used in Waypoint.

map -> mapTag

Very niche tag hogging a good name.

object -> objectTag

Requires backticks the way it is

from scala-dom-types.

cornerman avatar cornerman commented on May 20, 2024 1

I'll just throw in my opinion. I rarely use the id attribute in my code, therefore I am in favor of renaming the attribute to idAttr. For me, the usage pattern does not justify such a prominent name. Main factors are variable shadowing and surprises when moving code which use a variable named id.

from scala-dom-types.

fdietze avatar fdietze commented on May 20, 2024

I agree to all the renames!

from scala-dom-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.